fs: Fix fstat retarget for regular files #5203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC's newlib library depends on fstat to get in-flight information about a file's type an size. A working fstat for regular files is needed for seek and related functions to work correctly.
|
cc @kjbracey-arm |
kjbracey
reviewed
Sep 27, 2017
platform/mbed_retarget.cpp
Outdated
| return -1; | ||
| } | ||
|
|
||
| st->st_mode = S_IFREG; |
There was a problem hiding this comment.
Should this also indicate S_IFCHR if FileHandle::isatty()?
There was a problem hiding this comment.
Good point, should be updated
geky
force-pushed
the
fix-fstat-newlib
branch
from
4638bca to
0132691
Compare
kjbracey
approved these changes
Sep 28, 2017
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
The latest failure was not caused by this patch, master had to be patched, should be all good now /morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC's newlib library depends on fstat to get in-flight information about a file's type an size. A working fstat for regular files is needed for seek and related functions to work correctly.
Side note about testing this and #5183, I have tests inbound, which is what's finding these bugs. They're currently targeting littlefs here, but I will also bring them over the FAT filesystem once they're up and running.