Ticker: add dtor implementation #5217
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar issue is in |
c1728p9
reviewed
Sep 28, 2017
| @@ -22,6 +22,12 @@ | |||
|
|
|||
| namespace mbed { | |||
|
|
|||
| void Ticker::~Ticker() { | |||
There was a problem hiding this comment.
This should probably call detach to ensure no more interrupts can fire.
0xc0170
force-pushed
the
fix_ticker_dtor
branch
from
1be95ce to
4cb0a4b
Compare
Dtor should invoke detach
0xc0170
force-pushed
the
fix_ticker_dtor
branch
from
4cb0a4b to
01e1c07
Compare
|
Rebased (dtor invokes detach to clean its resources), resolved conflicts, now ready for CI |
|
/morph test |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
|
|
Not valid anymore, rebase resolved it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on #5148.
I'll rebase once that PR is integrated (CI now fails !), and will tag for review/tests
This addresses the issue reported here (#5067). If Ticker locked deepsleep, it should unlock it (clean its resources in this case) in dtor.
Should it also invoke
remove()in dtor?