Skip to content

Fix documentation of BLE GattCharacteristic #5229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

akosthekiss
Copy link
Contributor

The constructor doc incorrectly suggested that only short (16-bit)
UUIDs were accepted. The same doc also referred to properties
instead of characteristics. (And to "value length", which seemed to
be completely out of place in the context of the current code.)

Status

READY

Migrations

NO

@akosthekiss
Copy link
Contributor Author

Tried to track down why some CIs turned red but did not get far. (Travis is green, that's for sure.)

Circle CI reports:

Usage: nosetests [options]

nosetests: error: no such option: -v

((nosetests -v "--with-xunit --xunit-file=/tmp/circle-junit.3yam3fc/nosetests/nosetests.xml")) returned exit code 2

This seems to be unrelated to this PR.

To the Jenkins details, I have no access. Any directions are appreciated.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2017

@akosthekiss Hello, we are investigating CI failures. circle ci is now disabled, I am checking how this was enabled in first place.

@0xc0170 0xc0170 closed this Oct 2, 2017
@0xc0170 0xc0170 reopened this Oct 2, 2017
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2017

cc @pan-

@theotherjimmy
Copy link
Contributor

@akosthekiss Could you change the sha of the last commit to kick out Circle CI? You can do this with git commit --amend with no changes.

@akosthekiss
Copy link
Contributor Author

@theotherjimmy done

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented Oct 3, 2017

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test

@adbridge
Copy link
Contributor

adbridge commented Oct 3, 2017

retest uvisor

The constructor doc incorrectly suggested that only short (16-bit)
UUIDs were accepted. The same doc also referred to properties
instead of characteristics. (And to "value length", which seemed to
be completely out of place in the context of the current code.)
@akosthekiss
Copy link
Contributor Author

Thought I'd give CIs a chance to run again by rebasing PR to latest master.

@akosthekiss
Copy link
Contributor Author

What now? I feel a bit lost.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 6, 2017

@mazimkhan I can't acces uvisor CI link via details here? It was retriggered 3 days ago, can you review?

@akosthekiss I restarted jenkins CI, and we will run one more CI.

@akosthekiss
Copy link
Contributor Author

@mazimkhan @adbridge Could I ask for some help with Cam-CI uvisor, again?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 8, 2017

retest uvisor

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 8, 2017

/morph test

@mbed-bot
Copy link

mbed-bot commented Oct 8, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1546

All builds and test passed!

@akosthekiss
Copy link
Contributor Author

retest uvisor

@akosthekiss akosthekiss deleted the ble-service-doc-fix branch October 9, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants