-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix documentation of BLE GattCharacteristic #5229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tried to track down why some CIs turned red but did not get far. (Travis is green, that's for sure.) Circle CI reports:
This seems to be unrelated to this PR. To the Jenkins details, I have no access. Any directions are appreciated. |
@akosthekiss Hello, we are investigating CI failures. circle ci is now disabled, I am checking how this was enabled in first place. |
cc @pan- |
@akosthekiss Could you change the sha of the last commit to kick out Circle CI? You can do this with |
e941fb6
to
9466ef4
Compare
@theotherjimmy done |
/morph test |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
|
retest uvisor |
The constructor doc incorrectly suggested that only short (16-bit) UUIDs were accepted. The same doc also referred to properties instead of characteristics. (And to "value length", which seemed to be completely out of place in the context of the current code.)
9466ef4
to
87a2b5b
Compare
Thought I'd give CIs a chance to run again by rebasing PR to latest master. |
What now? I feel a bit lost. |
@mazimkhan I can't acces uvisor CI link via details here? It was retriggered 3 days ago, can you review? @akosthekiss I restarted jenkins CI, and we will run one more CI. |
@mazimkhan @adbridge Could I ask for some help with Cam-CI uvisor, again? |
retest uvisor |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
retest uvisor |
The constructor doc incorrectly suggested that only short (16-bit)
UUIDs were accepted. The same doc also referred to properties
instead of characteristics. (And to "value length", which seemed to
be completely out of place in the context of the current code.)
Status
READY
Migrations
NO