Add API to set ticker IRQ handler. #5234

mprse · 2017-10-02T08:16:11Z

Description

Add API to set IRQ handler for high frequency ticker and low power ticker.
This is done to be able to test HAL ticker API without using mbed upper layers to connect IRQ handler.

Status

READY

Migrations

YES
Add API to set IRQ handler for high frequency ticker and low power ticker.
Original IRQ handler is set as default ticker IRQ handler.

Related PRs

------ | ------
ARMmbed:feature-hal-spec-ticker | #5233

0xc0170 · 2017-10-02T08:41:37Z

hal/us_ticker_api.h

@@ -31,6 +31,15 @@ extern "C" {
 * @{
 */

+typedef void (*TICKER_IRQ_HANDLER_TYPE)(const ticker_data_t *const);


please for typedef use small letters, as any other implementation does in this codebase

0xc0170 · 2017-10-02T08:42:18Z

hal/mbed_us_ticker_api.c

@@ -38,5 +40,7 @@ const ticker_data_t* get_us_ticker_data(void)

 void us_ticker_irq_handler(void)
 {
-    ticker_irq_handler(&us_data);
+    if(irq_handler) {


should be if (

0xc0170 · 2017-10-02T08:42:56Z

cc @c1728p9 @pan- @bulislaw

bulislaw

Can we add docs (doxy) to the api headers saying that there's a default one used in both cases.

mprse · 2017-10-02T13:43:27Z

Added notes about default IRQ handlers. Modified functions which sets us/lp ticker IRQ handlers. In the new version this functions return previous handlers.

theotherjimmy · 2017-10-10T21:07:18Z

@AnotherButler Heads up: Doxygen API change.

mbed-ci · 2017-10-10T21:49:59Z

Build : FAILURE

Build number : 76
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5234/

0xc0170 · 2017-10-11T07:16:57Z

/morph build

0xc0170 · 2017-10-11T07:20:14Z

/morph test

mbed-ci · 2017-10-11T08:35:38Z

Build : FAILURE

Build number : 105
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5234/

0xc0170 · 2017-10-11T14:25:42Z

/morph build

mbed-ci · 2017-10-11T16:53:46Z

Build : SUCCESS

Build number : 127
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5234/

Triggering tests

/test mbed-os

mbed-ci · 2017-10-12T18:21:47Z

Test : FAILURE

Build number : 61
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5234/61

0xc0170 · 2017-10-13T08:46:00Z

Can we rebase the destination branch? Failures are expected I assume, but can we fix that branch to have tests passing?

mbed-ci · 2017-10-16T22:58:50Z

Test : FAILURE

Build number : 83
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5234/83

0xc0170 · 2017-10-18T14:47:14Z

/morph build

mbed-ci · 2017-10-18T15:22:07Z

Build : SUCCESS

Build number : 231
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5234/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-10-18T18:46:04Z

Test : SUCCESS

Build number : 115
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5234/115

0xc0170 · 2017-10-19T08:02:24Z

@bulislaw @c1728p9 approval for this extension, all testing done, can be ready !

c1728p9 · 2017-10-23T15:36:14Z

I didn't realize this was against the feature-hal-spec-ticker branch. This should probably go into master as well.

mprse mentioned this pull request Oct 2, 2017

Add tests for ticker HAL API. #5233

Merged

0xc0170 reviewed Oct 2, 2017

View reviewed changes

0xc0170 added the needs: review label Oct 2, 2017

mprse force-pushed the feature-hal-spec-ticker_irq_handler_set branch from 2be698c to 2cd341d Compare October 2, 2017 08:50

bulislaw reviewed Oct 2, 2017

View reviewed changes

mprse force-pushed the feature-hal-spec-ticker_irq_handler_set branch from 2cd341d to fc115f0 Compare October 2, 2017 13:42

Add API to set ticker IRQ handler.

6eab387

mprse force-pushed the feature-hal-spec-ticker_irq_handler_set branch from fc115f0 to 6eab387 Compare October 2, 2017 14:25

0xc0170 approved these changes Oct 4, 2017

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Oct 4, 2017

mprse mentioned this pull request Oct 9, 2017

Ticker interrupt executed periodically on K64F platform #5279

Closed

0xc0170 added needs: review and removed needs: CI labels Oct 19, 2017

c1728p9 approved these changes Oct 19, 2017

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Oct 19, 2017

bulislaw approved these changes Oct 20, 2017

View reviewed changes

theotherjimmy merged commit 291dd1d into ARMmbed:feature-hal-spec-ticker Oct 23, 2017

theotherjimmy removed the needs: CI label Oct 23, 2017

mprse mentioned this pull request Oct 24, 2017

Add API to set ticker IRQ handler. #5369

Merged

Add API to set ticker IRQ handler. #5234

Add API to set ticker IRQ handler. #5234

Uh oh!

Conversation

mprse commented Oct 2, 2017

Description

Status

Migrations

Related PRs

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Oct 2, 2017

Uh oh!

bulislaw left a comment

Choose a reason for hiding this comment

Uh oh!

mprse commented Oct 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theotherjimmy commented Oct 10, 2017

Uh oh!

mbed-ci commented Oct 10, 2017

Uh oh!

0xc0170 commented Oct 11, 2017

Uh oh!

0xc0170 commented Oct 11, 2017

Uh oh!

mbed-ci commented Oct 11, 2017

Uh oh!

0xc0170 commented Oct 11, 2017

Uh oh!

mbed-ci commented Oct 11, 2017

Triggering tests

Uh oh!

mbed-ci commented Oct 12, 2017

Uh oh!

0xc0170 commented Oct 13, 2017

Uh oh!

mbed-ci commented Oct 16, 2017

Uh oh!

0xc0170 commented Oct 18, 2017

Uh oh!

mbed-ci commented Oct 18, 2017

Triggering tests

Uh oh!

mbed-ci commented Oct 18, 2017

Uh oh!

0xc0170 commented Oct 19, 2017

Uh oh!

c1728p9 commented Oct 23, 2017

Uh oh!

Uh oh!

mprse commented Oct 2, 2017 •

edited

Loading