[EXPORT][NUCLEO_F334R8] export to gcc_arm and coide #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rtos library is not working because of double defined SysTick_Handler in system_stm32f3xx.c and in rtos - please see pullrequest ARMmbed#526 for a correct export - tests are working fine: Test summary: +--------+---------------+-----------+-----------+---------------------------------------+--------------------+---------------+-------+ | Result | Target | Toolchain | Test ID | Test Description | Elapsed Time (sec) | Timeout (sec) | Loops | +--------+---------------+-----------+-----------+---------------------------------------+--------------------+---------------+-------+ | OK | NUCLEO_F334R8 | GCC_ARM | DTCT_1 | Simple detect test | 0.44 | 10 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | EXAMPLE_1 | /dev/null | 3.37 | 10 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | MBED_10 | Hello World | 0.37 | 10 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | MBED_11 | Ticker Int | 11.31 | 20 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | MBED_12 | C++ | 1.32 | 10 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | MBED_16 | RTC | 4.7 | 15 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | MBED_2 | stdio | 0.76 | 20 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | MBED_23 | Ticker Int us | 11.37 | 15 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | MBED_24 | Timeout Int us | 11.41 | 15 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | MBED_25 | Time us | 11.31 | 15 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | MBED_26 | Integer constant division | 1.32 | 10 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | MBED_A1 | Basic | 1.32 | 10 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | MBED_A21 | Call function before main (mbed_main) | 1.31 | 10 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | MBED_A5 | DigitalIn DigitalOut | 1.31 | 10 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | MBED_A6 | DigitalInOut | 1.31 | 10 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | MBED_A7 | InterruptIn | 9.31 | 10 | 1/1 | | OK | NUCLEO_F334R8 | GCC_ARM | MBED_A9 | Serial Echo at 115200 | 5.97 | 10 | 1/1 | +--------+---------------+-----------+-----------+---------------------------------------+--------------------+---------------+-------+ Result: 17 OK Completed in 125.02 sec
| @@ -509,7 +509,7 @@ def __init__(self): | |||
| Target.__init__(self) | |||
| self.core = "Cortex-M0" | |||
| self.extra_labels = ["NORDIC", "NRF51822_MKIT", "MCU_NRF51822", "MCU_NORDIC_16K", "NRF51822"] | |||
| self.macros = ['TARGET_NRF51822', 'TARGET_OTA_ENABLED'] | |||
There was a problem hiding this comment.
Hi,
Why did you remove TARGET_OTA_ENABLED here (and below)?
Thanks,
Bogdan
The commit 'export to gcc_arm and coide' removed accidentally 2 macros from NRF51822 and NRF51 targets.
|
@bogdanm , I added the missing macros to both targets. |
|
Hello, I wonder why you closed this pull request? |
|
The last message was, that I should close the pull request and submit it with the solved conflict. That's why I closed it and resubmited the same code but without the conflict. Please see #556. I thought, the different commits will be combined to a single one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test summary:
+--------+---------------+-----------+-----------+---------------------------------------+--------------------+---------------+-------+
| Result | Target | Toolchain | Test ID | Test Description | Elapsed Time (sec) | Timeout (sec) | Loops |
+--------+---------------+-----------+-----------+---------------------------------------+--------------------+---------------+-------+
| OK | NUCLEO_F334R8 | GCC_ARM | DTCT_1 | Simple detect test | 0.44 | 10 | 1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | EXAMPLE_1| /dev/null | 3.37 | 10 | 1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | MBED_10 | Hello World | 0.37 | 10 | 1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | MBED_11 | Ticker Int | 11.31 | 20 | 1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | MBED_12 | C++ | 1.32 | 10 | 1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | MBED_16 | RTC | 4.7 | 15 | 1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | MBED_2 | stdio | 0.76 | 20 | 1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | MBED_23 | Ticker Int us | 11.37 | 15 | 1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | MBED_24 | Timeout Int us | 11.41 | 15 | 1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | MBED_25 | Time us | 11.31 | 15 | 1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | MBED_26 | Integer constant division|1.32| 10 | 1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | MBED_A1 | Basic | 1.32 | 10 | 1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | MBED_A21| Call function before main (mbed_main)|1.31|10|1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | MBED_A5 | DigitalIn DigitalOut | 1.31 | 10 | 1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | MBED_A6 | DigitalInOut | 1.31 | 10 | 1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | MBED_A7 | InterruptIn | 9.31 | 10 | 1/1 |
| OK | NUCLEO_F334R8 | GCC_ARM | MBED_A9 | Serial Echo at 115200 | 5.97 | 10 | 1/1 |
+--------+---------------+-----------+-----------+---------------------------------------+--------------------+---------------+-------+
Result: 17 OK
Completed in 125.02 sec