Skip to content

Update HeapBlockDevice example #5292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2017

Conversation

kegilbert
Copy link
Contributor

@kegilbert kegilbert commented Oct 10, 2017

Small example in the HeapBlockDevice header file was not valid, added size parameters to program and read calls.

@geky Wasn't sure who was the best person to put on here was, figured you were closest to filesystem changes at the moment and last touched this file. ¯/_(ツ)_/¯ Feel free to change the reviewer to someone else.

@kegilbert kegilbert requested a review from geky October 10, 2017 21:25
@geky
Copy link
Contributor

geky commented Oct 10, 2017

Ah, actually this example has definitely become a bit rotten.

  • Needs to call bd.erase before calling bd.program
  • How about we just #define BLOCK_SIZE at top? Then we can use BLOCK_SIZE for the erase/read/program calls

Use defined blocksize constant
@kegilbert
Copy link
Contributor Author

@geky: Updated. Should I erase the whole allocated block object or is just the block I'm using in the example fine?

@geky
Copy link
Contributor

geky commented Oct 10, 2017

Looks good 👍, just need to erase the first block. Think of a write as erase followed by program.

@mbed-ci
Copy link

mbed-ci commented Oct 10, 2017

Build : SUCCESS

Build number : 81
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5292/

Triggering tests

/test mbed-os

@mbed-ci
Copy link

mbed-ci commented Oct 10, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 11, 2017

retest uvisor

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2017

Test : SUCCESS

Build number : 41
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5292/41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants