Update of RTC HAL API specification and tests. #5306

mprse · 2017-10-12T11:46:35Z

Description

This patch provides updates of artefacts provided in PR #5226.

This patch provides the following updates:

description of RTC HAL API tests in given/when/then format,
minor fixes in existing test cases,
additional test cases.

Status

READY

Migrations

NO

Related PRs

feature-hal-spec-rtc | #5226
master | #5363

Todos

Provided additional test case rtc_enabled_test() is in conflict with rtc_persist_test() test case.

Documentation describes rtc_isenabled() function as follows:

RTC has the time set and is counting

I assume that some test should be created for this function, but its behaviour is unclear. I understand this description as follows:
"RTC is counting" - RTC has been initialised by means of rtc_init() function.
"RTC has the time set" - RTC time value has been set by means of rtc_write() function.
Since rtc_isenabled() can not be called before rtc_init(), test case which checks if rtc_isenabled() returns:

0 after initialisation and before time has been set,
1 after initialisation and time set operation,
has been created.
This case is inconsistent with test case which checks RTC persistence, which assumes that rtc_isenabled() returns 1 after rtc_init() call (if time has been set earlier).

mbed-ci · 2017-10-12T12:07:10Z

Build : FAILURE

Build number : 148
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5306/

mprse · 2017-10-12T13:18:35Z

Build : FAILURE

Build number : 148
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5306/

Added conditional compilation: sleep/deep-sleep tests available only for boards with low power timers.

mbed-ci · 2017-10-12T13:34:22Z

Build : SUCCESS

Build number : 155
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5306/

Triggering tests

/test mbed-os

0xc0170 · 2017-10-12T13:52:17Z

cc @c1728p9 @bulislaw

mprse · 2017-10-13T06:53:21Z

I'm not sure if this is failure reason, but in Travis log I have found only this error:

W: GPG error: http://repo.mongodb.org/apt/ubuntu trusty/mongodb-org/3.2 Release: The following signatures were invalid: KEYEXPIRED 1507497109

0xc0170 · 2017-10-13T07:01:05Z

@mprse I can see in the logs that doxygen check is red, that would be the failure, can you confirm?

mprse · 2017-10-13T07:22:15Z

can see in the logs that doxygen check is red, that would be the failure, can you confirm?

Thanks for the tip. It looks like there is some problem with doxygen formatting.

0xc0170 · 2017-10-19T10:41:32Z

Travis still fails $ find "(" -name "*.a" -or -name "*.ar" ")" -and -not -name "lib*" | tee BUILD/badlibs | sed -e "s/^/Bad library name found: /" && [ ! -s BUILD/badlibs ] . Please fix

mbed-ci · 2017-10-19T13:57:18Z

Build : SUCCESS

Build number : 266
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5306/

Skipping test trigger, missing label 'NEED CI'

0xc0170 · 2017-10-19T15:23:17Z

@mprse I restarted travis but we saw the failure regarding doxygen as previously reported.

mprse · 2017-10-20T13:05:49Z

@mprse I restarted travis but we saw the failure regarding doxygen as previously reported.

Provided fix.

theotherjimmy · 2017-10-23T15:05:48Z

cc @c1728p9 @bulislaw review please.

bulislaw · 2017-10-23T15:22:42Z

hal/rtc_api.h

@@ -30,37 +30,147 @@ extern "C" {
 #endif

 /**
- * \defgroup hal_rtc RTC hal functions
+ * \defgroup hal_rtc RTC hal


We are duplicating or even triplicating(?) if we count PG. I don't think this information should be in test header: defined/undefined behaviour + potential bugs could be only here.

This form has been provided here:
0a68abd PR #5226

And this PR has only extended provided test list.
I understand that we have the same information provided in both files:
rtc_api_tests.h and rtc_api.h (defined/undefined behaviour, potential bugs and list of test cases which verifies each requirement). You suggest to leave here "defined/undefined behaviour + potential bugs" - so only names of test cases should be removed? Additionally what PG means ?

Edit:
Example fix has been provided.

Ok so your PR has changes that are not yet on branch but will arrive in #5226? In this case lets not do that before the other PR is merged somewhere cause we don't know what we are reviewing.

bulislaw · 2017-10-23T15:23:55Z

hal/rtc_api.h

 * @{
 */

+/**
+ * \defgroup hal_rtc_tests RTC hal tests


That's already defined in test header, i don't think we need this block here.

bulislaw · 2017-10-23T15:24:38Z

hal/rtc_api.h

+ *
+ * @note This function is safe to call repeatedly - Tested by ::rtc_init_test
+ *
+ * Pseudo Code:


Can we comment on each of the example code, that's example implementation pseudo code, just to make it clear.

bulislaw · 2017-10-23T15:27:08Z

hal/rtc_api.h

 /** Initialize the RTC peripheral
 *
+ * Powerup the RTC in perpetration for access. This function must be called
+ * before any other RTC functions ares called. This does not change the state


Do we test that that actually does not change the state? Eg does not reset the counter?

rtc_persist_test() test case verifies if counter value is valid after free and re-initialisation (still counts).

adbridge · 2017-10-31T15:42:09Z

@bulislaw can you take a look at the update please ?

bulislaw · 2017-11-01T14:21:06Z

@mprse the #5226 was merged to the branch, can you rebase this PR please

0xc0170 · 2017-11-03T15:31:32Z

/morph build

mbed-ci · 2017-11-03T17:56:21Z

Build : SUCCESS

Build number : 429
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5306/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-11-04T00:22:31Z

Test : SUCCESS

Build number : 221
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5306/221

mbed-ci · 2017-11-04T01:16:14Z

Exporter Build : FAILURE

Build number : 78
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5306/

mprse · 2017-11-06T07:26:21Z

Exporter Build : FAILURE

Build number : 78
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5306/

There was a problem only on K66F platform/make_iar. It looks like this is some kind of environment configuration issue.
Log provided below:

00:48:48 Extracting sources done..
00:48:52 [mbed] WARNING: Could not find mbed program in current path "/builds/ws/exporter-build-matrix/78/K66F_make_iar/sources/examples/mbed-os-example-blinky".
00:48:52 [mbed] WARNING: You can fix this by calling "mbed new ." in the root of your program.
00:48:52 ---
00:49:39 [mbed] WARNING: Could not find mbed program in current path "/builds/ws/exporter-build-matrix/78/K66F_make_iar/sources/examples/mbed-os-example-sockets".
00:49:39 [mbed] WARNING: You can fix this by calling "mbed new ." in the root of your program.
00:49:39 ---
00:50:17 [mbed] WARNING: Could not find mbed program in current path "/builds/ws/exporter-build-matrix/78/K66F_make_iar/sources/examples/nanostack-border-router".
00:50:17 [mbed] WARNING: You can fix this by calling "mbed new ." in the root of your program.
00:50:17 ---
00:51:00 Completed 256.0 KiB/514.0 KiB (1.1 MiB/s) with 1 file(s) remaining
Completed 512.0 KiB/514.0 KiB (2.1 MiB/s) with 1 file(s) remaining
Completed 514.0 KiB/514.0 KiB (2.0 MiB/s) with 1 file(s) remaining
upload: ../../afb2d5c2f8e178461fe0fe53faa843b82de761ff_exporter_build_log_K66F_make_iar.txt to s3://mbed-os/builds/exporter/5306/FAIL/K66F/make_iar/afb2d5c2f8e178461fe0fe53faa843b82de761ff_exporter_build_log_K66F_make_iar.txt
00:51:01 upload of example bin failed
00:51:01 Build failed !!!
00:51:01 Build step 'Execute shell' marked build as failure
00:51:01 [BFA] Scanning build for known causes...
00:51:01 [BFA] No failure causes found
00:51:01 [BFA] Done. 0s
00:51:01 [WS-CLEANUP] Deleting project workspace...[WS-CLEANUP] done
00:51:01 Finished: FAILURE

0xc0170 · 2017-11-06T09:06:02Z

/morph export-build

mbed-ci · 2017-11-06T10:25:32Z

Exporter Build : FAILURE

Build number : 84
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5306/

0xc0170 · 2017-11-06T15:03:28Z

I reviewed the 2 failures from exporters. This is the error reported from IAR: [mbed-os/rtos/TARGET_CORTEX/rtx5/TARGET_RTOS_M4_M7/TOOLCHAIN_IAR/irq_cm4f.o] Segmentation fault (core dumped) . As this patch does not changes anything in RTX, and the fault does not produce more information. I am suspicios it might be more generic problem than this PR.

I'll run one exporter in another PR and do a local as well.

@mprse If you can test locally also if you can reproduce the failure with IAR here. I haven't seen this report in any other PR so far.

0xc0170 · 2017-11-06T16:26:01Z

FYI, https://mbed-os.mbedcloudtesting.com/job/exporter-build-matrix/86/ - latest run on another PR that is going to master and all OK.

studavekar · 2017-11-06T20:42:59Z

@0xc0170 fix for IAR failure #5415 is on master and probably not on branch feature-hal-spec-rtc because of which exporter test failed ?

0xc0170 · 2017-11-07T10:23:51Z

@0xc0170 fix for IAR failure #5415 is on master and probably not on branch feature-hal-spec-rtc because of which exporter test failed ?

Good catch, that is correct. @mprse the RTC branch needs an update, can you please?

mprse · 2017-11-07T10:58:40Z

Good catch, that is correct. @mprse the RTC branch needs an update, can you please?

Rebase to master: PR #5447

studavekar · 2017-11-08T03:44:52Z

/morph export-build

studavekar · 2017-11-08T05:41:58Z

Aborting the exporter test for this PR.

Provide minor fixes for existing test cases. Add additional test cases.

mprse · 2017-11-10T13:07:05Z

Rebased mprse:feature-hal-spec-rtc_tests-update branch to ARMmbed:feature-hal-spec-rtc.

0xc0170 · 2017-11-10T13:14:01Z

/morph build

mbed-ci · 2017-11-10T14:40:50Z

Build : SUCCESS

Build number : 492
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5306/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2017-11-10T16:25:05Z

Test : SUCCESS

Build number : 310
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5306/310

mbed-ci · 2017-11-10T17:10:12Z

Exporter Build : SUCCESS

Build number : 113
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5306/

mprse force-pushed the feature-hal-spec-rtc_tests-update branch from cf1a596 to 38566b7 Compare October 12, 2017 11:47

mprse force-pushed the feature-hal-spec-rtc_tests-update branch 2 times, most recently from ae871bf to b8b1416 Compare October 12, 2017 13:16

0xc0170 added the needs: review label Oct 12, 2017

mprse force-pushed the feature-hal-spec-rtc_tests-update branch from b8b1416 to 1ea37cd Compare October 13, 2017 07:20

0xc0170 added needs: work and removed needs: review labels Oct 19, 2017

mprse force-pushed the feature-hal-spec-rtc_tests-update branch 2 times, most recently from a6b2b8f to a95d01a Compare October 19, 2017 13:37

mprse force-pushed the feature-hal-spec-rtc_tests-update branch 2 times, most recently from a0bc0f8 to 2aad555 Compare October 20, 2017 08:49

theotherjimmy added needs: review and removed needs: work labels Oct 23, 2017

bulislaw reviewed Oct 23, 2017

View reviewed changes

mprse force-pushed the feature-hal-spec-rtc_tests-update branch from 2aad555 to 08734f1 Compare October 24, 2017 07:55

mprse force-pushed the feature-hal-spec-rtc_tests-update branch from 08734f1 to afb2d5c Compare November 2, 2017 09:21

0xc0170 added needs: CI and removed needs: review labels Nov 3, 2017

c1728p9 force-pushed the feature-hal-spec-rtc branch from d312da9 to 5e6c46e Compare November 9, 2017 21:44

mprse added 2 commits November 10, 2017 13:56

Modify rtc_api.h header file - update tests specification.

3fd7e1d

Update of RTC HAL API tests.

df26cab

Provide minor fixes for existing test cases. Add additional test cases.

mprse force-pushed the feature-hal-spec-rtc_tests-update branch from afb2d5c to df26cab Compare November 10, 2017 12:57

0xc0170 added ready for merge and removed needs: CI labels Nov 13, 2017

theotherjimmy merged commit e4b78b3 into ARMmbed:feature-hal-spec-rtc Nov 13, 2017

theotherjimmy removed the ready for merge label Nov 13, 2017

mprse mentioned this pull request Nov 15, 2017

Add tests for ticker HAL API. #5233

Merged

Update of RTC HAL API specification and tests. #5306

Update of RTC HAL API specification and tests. #5306

Uh oh!

Conversation

mprse commented Oct 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Status

Migrations

Related PRs

Todos

Uh oh!

mbed-ci commented Oct 12, 2017

Uh oh!

mprse commented Oct 12, 2017

Uh oh!

mbed-ci commented Oct 12, 2017

Triggering tests

Uh oh!

0xc0170 commented Oct 12, 2017

Uh oh!

mprse commented Oct 13, 2017

Uh oh!

0xc0170 commented Oct 13, 2017

Uh oh!

mprse commented Oct 13, 2017

Uh oh!

0xc0170 commented Oct 19, 2017

Uh oh!

mbed-ci commented Oct 19, 2017

Uh oh!

0xc0170 commented Oct 19, 2017

Uh oh!

mprse commented Oct 20, 2017

Uh oh!

theotherjimmy commented Oct 23, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mprse Oct 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adbridge commented Oct 31, 2017

Uh oh!

bulislaw commented Nov 1, 2017

Uh oh!

0xc0170 commented Nov 3, 2017

Uh oh!

mbed-ci commented Nov 3, 2017

Triggering tests

Uh oh!

mbed-ci commented Nov 4, 2017

Uh oh!

mbed-ci commented Nov 4, 2017

Uh oh!

mprse commented Nov 6, 2017

Uh oh!

0xc0170 commented Nov 6, 2017

Uh oh!

mbed-ci commented Nov 6, 2017

Uh oh!

0xc0170 commented Nov 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Nov 6, 2017

mprse commented Oct 12, 2017 •

edited

Loading

mprse Oct 24, 2017 •

edited

Loading

0xc0170 commented Nov 6, 2017 •

edited

Loading