Tools: Check for toolchain and core support for Arm Compilers #5317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theotherjimmy
force-pushed
the
fix-arm-supported-check
branch
2 times, most recently
from
e05fd32 to
1a633f2
Compare
theotherjimmy
force-pushed
the
fix-arm-supported-check
branch
from
1a633f2 to
4673fb6
Compare
|
@theotherjimmy tests addition only missing here? |
Closed
|
@0xc0170 Correct. |
|
Please close #5345 as soon as this PR is merged |
|
@jeromecoutant I updated the PR description to include the Fixes tag. #5345 will be closed when this PR is merged. |
They fail right now, Cores are not checked
theotherjimmy
changed the title
|
@0xc0170 I added the tests. If Travis CI passes, then my implementation is correct. |
|
/morph build |
Build : SUCCESSBuild number : 307 Triggering tests/morph test |
Test : SUCCESSBuild number : 138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5266 when deployed to the online compiler
Fixes #5345
Also corrects offline compiling of uARM for every target that supports uARM but
not ARM.
TODO: