Skip to content

LPC1768: Fix ETHMEM_SECTION placement for ARM #5322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2017

Conversation

chrissnow
Copy link
Contributor

Description

Ethernet on LPC1768 is broken in 5.6 as per #5298
This corrects the placement of Ethernet memory with the ARM compiler.

Status

READY

Migrations

NO

Related PRs

branch PR

Todos

Deploy notes

Steps to test or reproduce

Build the TCPSocket_Example with 5.5.7 and it will work, any 5.6\master will fail to get an IP, using static IP will still fail to work properly.

Fixes #5298

@chrissnow chrissnow mentioned this pull request Oct 15, 2017
@chrissnow chrissnow changed the title Fix ETHMEM_SECTION placement for ARM on LPC1768 LPC1768: Fix ETHMEM_SECTION placement for ARM Oct 15, 2017
@adbridge
Copy link
Contributor

@SeppoTakalo please review

@mbed-ci
Copy link

mbed-ci commented Oct 17, 2017

Build : FAILURE

Build number : 192
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5322/

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 18, 2017

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 18, 2017

/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Oct 18, 2017

Build : SUCCESS

Build number : 237
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5322/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Oct 18, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2017

/morph uvisor-test

1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 19, 2017

/morph uvisor-test

@chrissnow
Copy link
Contributor Author

@0xc0170 CI seems to have got stuck?

@adbridge
Copy link
Contributor

@chrissnow looks like this now needs a rebase unforntunately...

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 26, 2017

@0xc0170 CI seems to have got stuck?

We are currently seeing some failures with infrastrastructure, that should be resolved soon. Once conflict resolved, we will restart CI.

@chrissnow
Copy link
Contributor Author

Rebased.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 26, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 26, 2017

Build : SUCCESS

Build number : 343
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5322/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Oct 26, 2017

@chrissnow
Copy link
Contributor Author

Failed due to an unrelated NRF51 error.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 27, 2017

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 27, 2017

@theotherjimmy
Copy link
Contributor

@studavekar It looks like some of these "in progress" indicators are incorrect.

@studavekar
Copy link
Contributor

studavekar commented Nov 2, 2017

@theotherjimmy fixed the status. possible reason for this is : KostyaSha/github-integration-plugin#215

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 3, 2017

/morph uvisor-test

1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 8, 2017

/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Nov 8, 2017

Build : SUCCESS

Build number : 458
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5322/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Nov 8, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 9, 2017

@alzix Please trigger uvisor for this patch (seems it is not active for us at the moment for some reason)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants