Skip to content

ChainingBlockDevice: fix changing blocks address #5375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2017
Merged

ChainingBlockDevice: fix changing blocks address #5375

merged 1 commit into from
Oct 30, 2017
+3 −3

Conversation

kegilbert
Copy link
Contributor

Change address subtraction when moving through block devices to be the size of the entire block device not the block size.

@kegilbert
Change address subtraction when moving through block devices to be th…
a746f95 
…e size of the entire block device not the block size
@kegilbert kegilbert requested a review from geky October 24, 2017 23:32
geky
geky approved these changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@geky geky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 25, 2017

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 25, 2017

@tommikas I noticed you restarted a job here, and resulted in an exception (few other jobs as well), please can you help resolving them?

@mbed-ci
Copy link

mbed-ci commented Oct 25, 2017

Build : FAILURE

Build number : 329
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5375/

@tommikas
Copy link
Contributor

Restarted again. Exceptions like that are usually momentary hiccups rather than a systematic problem.

@adbridge
Copy link
Contributor

adbridge commented Oct 26, 2017 •
edited
Loading

@studavekar CI issue ?

18:34:03 ERROR: Error cloning remote repo 'origin'

I will restart morph build and see if it goes away..

/morph build

@kegilbert
Copy link
Contributor Author

@studavekar said the problem should be resolved, rekicking off
/morph build

@studavekar
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 26, 2017

Build : SUCCESS

Build number : 345
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5375/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Oct 26, 2017

Test : SUCCESS

Build number : 156
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5375/156

@0xc0170 0xc0170 changed the title Fix ChainingBlockDevice address logic when changing blocks ChainingBlockDevice: changing blocks address fix Oct 26, 2017
@theotherjimmy theotherjimmy merged commit 27533ff into ARMmbed:master Oct 30, 2017
@theotherjimmy theotherjimmy changed the title ChainingBlockDevice: changing blocks address fix ChainingBlockDevice: fix changing blocks address Oct 30, 2017
@kegilbert kegilbert deleted the chainingbd-address-iter-fix branch October 30, 2017 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geky geky geky approved these changes

Assignees
No one assigned
Labels
release-version: 5.6.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kegilbert @0xc0170 @mbed-ci @tommikas @adbridge @studavekar @geky @theotherjimmy