Skip to content

SlicingBD: replace second constructor with default parameter #5385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2017

Conversation

kegilbert
Copy link
Contributor

Slightly simplifies the SlicingBlockDevice constructor setup. Example in the header still works correctly.

@geky

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 25, 2017

@tommikas Can you look at the CI failure please, does look to me like internal error.

@tommikas
Copy link
Contributor

Yep, Jenkins sometimes throws errors like that. Usually it's not systematic, and this too passed after restarting.

@0xc0170 0xc0170 requested a review from geky October 26, 2017 13:49
@0xc0170 0xc0170 changed the title Replace second SlicingBlockDevice constructor with default end parameter SlicingBlockDevice: constructor with default end parameter Oct 26, 2017
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 26, 2017

@kegilbert First line of the commit msg should not exceed 50 characters (I edited the headline here, please review). You can provide more information in the next paragraph in the commit msg.

Replace second ctor in SlicingBlockDevice with default parameter for the end address in first ctor
@kegilbert kegilbert force-pushed the slicingbd-ctor-rework branch from 6040f1d to 84e3110 Compare October 26, 2017 16:51
@kegilbert kegilbert changed the title SlicingBlockDevice: constructor with default end parameter SlicingBD: replace second constructor with default parameter Oct 26, 2017
@kegilbert
Copy link
Contributor Author

@0xc0170 I updated the commit and title, thanks for the heads up!

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 26, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 26, 2017

Build : SUCCESS

Build number : 346
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5385/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Oct 26, 2017

Copy link
Contributor

@geky geky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, yay a use for -0

@kegilbert
Copy link
Contributor Author

kegilbert commented Oct 26, 2017

@kegilbert
Copy link
Contributor Author

Looks like all tests for the NCS36510 and NRF51_DK timed out.
@studavekar Should I rekick off the morph test?

@studavekar
Copy link
Contributor

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 27, 2017

@theotherjimmy theotherjimmy merged commit 7b2e9b1 into ARMmbed:master Oct 30, 2017
@kegilbert kegilbert deleted the slicingbd-ctor-rework branch October 30, 2017 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants