-
Notifications
You must be signed in to change notification settings - Fork 3k
SlicingBD: replace second constructor with default parameter #5385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tommikas Can you look at the CI failure please, does look to me like internal error. |
Yep, Jenkins sometimes throws errors like that. Usually it's not systematic, and this too passed after restarting. |
@kegilbert First line of the commit msg should not exceed 50 characters (I edited the headline here, please review). You can provide more information in the next paragraph in the commit msg. |
Replace second ctor in SlicingBlockDevice with default parameter for the end address in first ctor
6040f1d
to
84e3110
Compare
@0xc0170 I updated the commit and title, thanks for the heads up! |
/morph build |
Build : SUCCESSBuild number : 346 Triggering tests/morph test |
Test : FAILUREBuild number : 157 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, yay a use for -0
Looks like all tests for the NCS36510 and NRF51_DK timed out. |
/morph test |
Test : SUCCESSBuild number : 165 |
Slightly simplifies the SlicingBlockDevice constructor setup. Example in the header still works correctly.
@geky