Skip to content

ncs36510: fire interrupt correct timer fix #5390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2017
Merged

ncs36510: fire interrupt correct timer fix #5390

merged 1 commit into from
Nov 9, 2017

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Oct 27, 2017

Use Timer1, it is used for us ticker isr handling. Plus reset target counter,
that should be 0, go to upper ticker isr handler immediately.

Found during #5307

cc @maciejbocianski @danclement @jacobjohnson-ON

@0xc0170
ncs36510: fire interrupt correct timer fix
99f4961 
Use Timer1, it is used for us ticker isr handling. Plus reset target counter,
that should be 0, go to upper ticker isr handler immediately.
@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 28, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 28, 2017

Build : SUCCESS

Build number : 364
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5390/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Oct 28, 2017

Test : SUCCESS

Build number : 176
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5390/176

This was referenced Oct 30, 2017
Closed
Merged
@adbridge
Copy link
Contributor

@maciejbocianski @danclement @jacobjohnson-ON Could you please review ?

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 6, 2017

Anyone to review this patch? It would unblock another patch adding tests!

@mbed-ci
Copy link

mbed-ci commented Nov 6, 2017

Build : SUCCESS

Build number : 443
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5390/

Triggering tests

/morph test
/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Nov 6, 2017

Test : FAILURE

Build number : 251
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5390/251

@mbed-ci
Copy link

mbed-ci commented Nov 6, 2017

Test : SUCCESS

Build number : 253
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5390/253

@0xc0170 0xc0170 mentioned this pull request Nov 7, 2017
Closed
@fkjagodzinski fkjagodzinski mentioned this pull request Nov 7, 2017
Merged
@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 7, 2017 •
edited
Loading

To get some verification, the above reference PR 5046 fails without this patch.

Before this patch

-+--------+--------------------+
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert                       | 1      | 0
 | OK     | 0.1                |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert_absolute              | 1      | 0
 | OK     | 0.1                |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert_absolute zero         | 0      | 1
 | FAIL   | 0.09               |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test remove after insert          | 1      | 0
 | OK     | 0.21               |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test remove after insert_absolute | 1      | 0
 | OK     | 0.21               |
+------------------+---------------+-------------------------------+-----------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 1 FAIL / 4 OK

with this patch

+------------------+---------------+-------------------------------+----------------------------------------------+--------+--------+--------+--------------------+
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert                                  | 1
   | 0      | OK     | 0.08               |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert timestamp from the past          | 1
   | 0      | OK     | 0.07               |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert_absolute                         | 1
   | 0      | OK     | 0.09               |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert_absolute timestamp from the past | 1
   | 0      | OK     | 0.07               |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test insert_absolute zero                    | 1
   | 0      | OK     | 0.05               |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test remove after insert                     | 1
   | 0      | OK     | 0.2                |
| NCS36510-GCC_ARM | NCS36510      | tests-mbed_drivers-timerevent | Test remove after insert_absolute            | 1
   | 0      | OK     | 0.21               |
+------------------+---------------+-------------------------------+----------------------------------------------+--------+--------+--------+--------------------+
mbedgt: test case results: 7 OK

The above numbers of test cases diff (I merged to master first the test PR then mine). The importance is in the FAIL -> OK

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 7, 2017

@fkjagodzinski Please review, see the latest comment with the test results

fkjagodzinski
fkjagodzinski approved these changes Nov 7, 2017
View reviewed changes
Copy link
Member

@fkjagodzinski fkjagodzinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice to see tests passed.

@0xc0170 0xc0170 merged commit 2b39144 into ARMmbed:master Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkjagodzinski fkjagodzinski fkjagodzinski approved these changes

Assignees
No one assigned
Labels
release-version: 5.6.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xc0170 @mbed-ci @adbridge @fkjagodzinski