Deprecate CallChain and InterruptManager #5393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch deprecates the InterruptManager class since it is an internal API (not in mbed.h) which is not being used anywhere in the codebase.
This patch deprecates the CallChain class since it is an internal API (not in mbed.h) and is only being used by InterruptManager which is also deprecated.
c1728p9
force-pushed
the
call_chain_deprecation
branch
from
db98775 to
891b06e
Compare
|
CC @0xc0170, @bogdanm, @pan-, @geky, @deepikabhavnani |
|
/morph build |
Build : SUCCESSBuild number : 362 Triggering tests/morph test |
Test : SUCCESSBuild number : 174 |
geky
approved these changes
Oct 28, 2017
| // class is deprecated already | ||
| #include "mbed_toolchain.h" | ||
| #undef MBED_DEPRECATED_SINCE | ||
| #define MBED_DEPRECATED_SINCE(...) |
theotherjimmy
added
needs: CI
ready for merge
release-version: 5.7.0-rc1
needs: review
and removed
needs: review
needs: CI
ready for merge
labels
|
Could we get another reviewer on this one? |
deepikabhavnani
approved these changes
Nov 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the CallChain and InterruptManager classes since these are dead code which is not part of mbed-os's public API.