RtosTimer tests update #5425
Merged
RtosTimer tests update #5425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional delay is needed to prevent random failures when waiting for a semaphore.
bulislaw
reviewed
Nov 3, 2017
| Case("Test calls from ISR fail", test_isr_calls_fail) | ||
| Case("One-shot not restarted when elapsed", test_oneshot_not_restarted), | ||
| Case("Periodic repeats continuously", test_periodic_repeats), | ||
| Case("Stopped timer can be started again", test_start_again), |
There was a problem hiding this comment.
Why are we removing one of the tests?
There was a problem hiding this comment.
Sorry, I should have mentioned that. I decided to remove test_restart because it basically duplicates test_restart_updates_delay with a different delay.
bulislaw
approved these changes
Nov 3, 2017
|
/morph build |
Build : SUCCESSBuild number : 462 Triggering tests/morph test |
Test : SUCCESSBuild number : 282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
RtosTimertest suite needs a fix/workaround for NRF51_DK board. As pointed out in this comment on #5323tests-mbedmicro-rtos-mbed-rtostimerfailed during ci-morph-test of a PR not related toRtosTimer. I'm unable to reproduce this behaviour on my NRF51_DK locally, but have found several failed ci-morph-tests:They all fail on line 74, 115 or 232:
mbed-os/TESTS/mbedmicro-rtos-mbed/rtostimer/main.cpp
Lines 74 to 76 in 6912a9d
mbed-os/TESTS/mbedmicro-rtos-mbed/rtostimer/main.cpp
Lines 113 to 115 in 6912a9d
mbed-os/TESTS/mbedmicro-rtos-mbed/rtostimer/main.cpp
Lines 230 to 232 in 6912a9d
which means either
semis never released or there is a timing issue. Considering all failures happened on NRF51_DK target I assume a longer timeout is needed to prevent these random failures.I've pushed one additional commit with code cleanup.
Status
READY
cc @bulislaw @0xc0170