Skip to content

Tests for wifi emac interface #5435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Tests for wifi emac interface #5435

merged 1 commit into from
Jan 4, 2018

Conversation

mikaleppanen
Copy link

Description

Added basic greentea tests for EMAC wifi interface. The test case inserts it between emac driver and lwip to be able to sent and received messages.

Protocol used for testing is "ethernet configuration testing protocol" (CTP). One device in ethernet segment needs to be configured as CTP echo server, to reply to messages sent by device that is tested. Test case .json file can be used to configure different settings for test case/echo server.

Status

READY

Migrations

NO

Related PRs

None

Todos

  • Tests
  • Documentation

Deploy notes

None

Steps to test or reproduce

None

@mikaleppanen
Copy link
Author

@SeppoTakalo @kjbracey-arm @KariHaapalehto please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 16, 2017

There's lot of test code but I do not see much documentation (do I need to read the code to find out what is being tested and how) ?

Is this dependant on any other PR (I would assume emac feature) ?

How we can test this in CI ?

Copy link
Contributor

@KariHaapalehto KariHaapalehto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several .h-files are missing copyright staments

Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing README.md

@theotherjimmy
Copy link
Contributor

@SeppoTakalo Where would you expect to find a README.md? What should it contain?

@mikaleppanen
Copy link
Author

Added readme.md and copyright statements to headers.

@adbridge
Copy link
Contributor

@SeppoTakalo Are you happy with the changes ?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 2, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 2, 2018

Build : SUCCESS

Build number : 782
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5435/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 2, 2018

@mbed-ci
Copy link

mbed-ci commented Jan 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants