-
Notifications
You must be signed in to change notification settings - Fork 3k
Unity framework : add float support in error print #5469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just for info, Is there any size increase with this enablement? |
You're right: before: after: |
Is it necessary to support double precision ? |
I agree, UNITY_FLOAT_VERBOSE is enough But we save only 8 bytes: |
shall we change it ? |
@jeromecoutant What is your opinion for this? Does this need an update? |
8f971ac
to
da37975
Compare
Update done Thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the Unity help:
define UNITY_FLOAT_VERBOSE to print floating point values in errors (uses sprintf)
So this change looks good to me
/morph build |
Build : SUCCESSBuild number : 632 Triggering tests/morph test |
Test : SUCCESSBuild number : 456 |
Exporter Build : SUCCESSBuild number : 259 |
Description
It is useful to get some information about FAIL tests.
This define adds the float support in the error prints
Ex before:
[1510238846.92][CONN][RXD] :316::FAIL: Values Not Within Delta
With the patch:
[1510238777.90][CONN][RXD] :316::FAIL: Expected 1.000000 Was 0.999424
Thx
Status
READY