Add tests for Sleep HAL API #5509

mprse · 2017-11-16T07:51:43Z

Description

This PR provides:

HAL Sleep test case specification to the sleep_api.h file.
test and test header to Sleep HAL API.

Status

READY

Migrations

NO

Related PRs

Todos

Implementation of the following test cases still needs to be added:

RTC should wake up a target from this mode - RTC alarm functionality is not yet available.
a watchdog timer should wake up a target from this mode - watchdog functionality is not yet available.
the processor can be woken up by external pin interrupt - @bulislaw @theotherjimmy @0xc0170 I need some information how CI environment is build and if there is any option to create such case. I tried to set USBRX pin as interrupt input pin and send some data from python part of test in order to wake up the board from sleep. This solution worked on K64F, but on NUCLEOF070RB did not - it looks like this pin could not be used as interrupt input.
We need some general solution for all boards. From my point of view we need additional board which could be controlled by Green Tea in order to control its pins. For this test we would need to set specified pin on additional board as output and then be able to modify its logic level. This pin have to be connected to the specific pin in the tested boards. Then test could use this specific pin as interrupt input pin in order to wake up board from sleep.
What do you think?
Maybe some solution for this type of tests is already available if yes, then can some provide some piece of information how to use it?

bulislaw

I don't think we can test the GPIO wake up with current CI setup.

bulislaw · 2017-11-17T14:39:59Z

hal/sleep_api.h

@@ -27,6 +27,42 @@
 extern "C" {
 #endif

+/**


What is that? That should be on the branch already?

I added requirements section since it wasn't available on this branch. Requirements have been created based on function descriptions which are precise.

That explains it, thanks @mprse

bulislaw · 2017-11-21T10:28:59Z

@mprse ping

mprse · 2017-11-22T06:54:42Z

If GPIO wake-up can not be tested, then this PR is ready for now.
Additional test cases will have to be added when watchdog timer and RTC alarm modules are ready.

0xc0170 · 2017-11-22T13:08:08Z

/morph build

mbed-ci · 2017-11-22T14:10:44Z

Build : FAILURE

Build number : 574
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5509/

mprse · 2017-11-22T14:42:54Z

    [Error] main.cpp@118,0:  #20: identifier "get_lp_ticker_data" is undefined
    [Error] main.cpp@131,0:  #20: identifier "lp_ticker_read" is undefined
    [Error] main.cpp@132,0:  #20: identifier "lp_ticker_set_interrupt" is undefined

Fix has been provided for targets without low power timers.

bulislaw · 2017-11-23T15:31:56Z

/morph build

mbed-ci · 2017-11-23T16:09:44Z

Build : FAILURE

Build number : 582
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5509/

bulislaw · 2017-11-23T16:14:48Z

NOT SUPPORTED should be NOT_SUPPORTED -> _ matters

mprse · 2017-11-24T07:52:57Z

NOT SUPPORTED should be NOT_SUPPORTED -> _ matters

Fixed as suggested.

0xc0170

rtc_sleep_test is part of RTC feature branch?

0xc0170 · 2017-11-24T09:09:07Z

/morph build

mprse · 2017-11-24T09:30:33Z

rtc_sleep_test is part of RTC feature branch?

Yes its already on ARMmbed:feature-hal-spec-rtc. I didn't want to duplicate tests.

mbed-ci · 2017-11-24T09:41:40Z

Build : SUCCESS

Build number : 585
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5509/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2017-11-24T10:44:00Z

Exporter Build : SUCCESS

Build number : 197
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5509/

mbed-ci · 2017-11-24T11:28:36Z

Test : FAILURE

Build number : 398
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5509/398

0xc0170 · 2017-11-24T13:23:55Z

@mprse Please review the tests results, 3 targets might break the expected behavior

mprse · 2017-11-24T14:08:05Z

Target	Result	Comment
NCS36510-ARM	:76::FAIL: Values Not Within Delta 16 Expected 6280721 Was 6280741	waking from sleep exceeds limit (10 us)
NCS36510-GCC_ARM	:77::FAIL: Values Not Within Delta 16 Expected 6326302 Was 6326323	waking from sleep exceeds limit (10 us)
NCS36510-IAR	:77::FAIL: Values Not Within Delta 16 Expected 6293332 Was 6293353	waking from sleep exceeds limit (10 us)
NRF51_DK-ARM	:76::FAIL: Values Not Within Delta 16 Expected 2375956 Was 2376190	waking from sleep exceeds limit (10 us)
NRF51_DK-GCC_ARM	Timeout	us ticker interrupt did not wake up target from sleep
NRF51_DK-IAR	Timeout	us ticker interrupt did not wake up target from sleep
NRF52_DK-ARM	:76::FAIL: Values Not Within Delta 16 Expected 6375712 Was 6375793	waking from sleep exceeds limit (10 us)
NRF52_DK-GCC_ARM	:77::FAIL: Values Not Within Delta 16 Expected 2381968 Was 2382019	waking from sleep exceeds limit (10 us)
NRF52_DK-IAR	Timeout	us ticker interrupt did not wake up target from sleep

mprse · 2017-11-24T14:31:04Z

Note:
Sleep test assume that we have new ticker drivers:

ticker counter counts ticks not us and is incremented by one,
ticker has defined frequency,
based on ticker frequency ticker count is converted to us.

I believe that most boards have ticker drivers are not ready. As far as I remember ticker frequency for all targets is declared as 1 MHz. I remember that on NRF51_DK high frequency ticker has 32kHz frequency, but it is scaled to 1MHz - incremented by 32. This might cause some us<-->ticks conversion problems.

bulislaw · 2017-11-27T11:42:04Z

@mprse it's 3 boards, can we fix them? Or work it around another way?

mbed-ci · 2018-01-11T13:36:49Z

Exporter Build : FAILURE

Build number : 504
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5509/

0xc0170 · 2018-01-11T13:47:13Z

We are investigating the failure in exporters (some of the last builds have the same problem)

mbed-ci · 2018-01-11T15:11:59Z

Test : FAILURE

Build number : 684
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5509/684

mprse · 2018-01-12T06:45:19Z

In the last test run only sleep tests have failed on NFR52_DK. This means that there is a relation between disabling SLEEP support on this board and problems with other tests. Try to disable also features which are related to sleep mode.

0xc0170 · 2018-01-12T08:34:44Z

/morph build

mbed-ci · 2018-01-12T08:51:10Z

Build : SUCCESS

Build number : 846
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5509/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-12T10:10:48Z

Exporter Build : SUCCESS

Build number : 515
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5509/

mbed-ci · 2018-01-12T11:13:35Z

Test : FAILURE

Build number : 690
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5509/690

mprse · 2018-01-12T11:21:08Z

The results are better but still two tests did not pass on NRF52_DK/IAR:

tests-mbed_drivers-timer
tests-mbed_drivers-ticker.

0xc0170 · 2018-01-12T12:09:38Z

/morph test

mbed-ci · 2018-01-12T16:24:53Z

Test : FAILURE

Build number : 695
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5509/695

mprse · 2018-01-15T10:23:57Z

For NRF52_DK removing of "SLEEP" feature causes some timing issues which have influence on tests. In order to successfully disable this board related features like "USTICKER", "LOWPOERTIMER" have been disabled and ticker tests were slightly modified, so they will not be executed if usticker support is not available (by default all targets support us ticker).

These boards will be re-enabled when sleep driver for them is ready. Note: This operation is done by removing "SLEEP" feature from target's "device_has" list (in targets.json config file). For NRF52_DK removing of "SLEEP" feature causes some timing issues which have influence on tests. In order to successfully disable this board we need to disable also related features like "USTICKER", "LOWPOERTIMER" and slightly modify ticker tests, so they will not be executed if usticker support is not available (by default all targets support us ticker).

0xc0170 · 2018-01-15T10:40:21Z

/morph build

mbed-ci · 2018-01-15T11:35:23Z

Build : SUCCESS

Build number : 865
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5509/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-15T13:05:36Z

Exporter Build : FAILURE

Build number : 536
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5509/

0xc0170 · 2018-01-15T13:20:56Z

/morph export-build

mbed-ci · 2018-01-15T13:52:53Z

Exporter Build : SUCCESS

Build number : 537
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5509/

mbed-ci · 2018-01-15T15:49:11Z

Test : SUCCESS

Build number : 712
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5509/712

bulislaw · 2018-01-15T17:17:05Z

Is that ready to go?

mprse · 2018-01-15T17:23:28Z

Finally CI has passed. Three boards are disabled. Its ready to go.

0xc0170 added the needs: review label Nov 16, 2017

0xc0170 requested review from c1728p9 and bulislaw November 16, 2017 15:56

bulislaw reviewed Nov 17, 2017

View reviewed changes

bulislaw approved these changes Nov 22, 2017

View reviewed changes

mprse force-pushed the feature-hal-spec-sleep_tests branch from 3875e15 to 92e02e4 Compare November 22, 2017 14:39

bulislaw added needs: CI and removed needs: review labels Nov 23, 2017

mprse force-pushed the feature-hal-spec-sleep_tests branch from 92e02e4 to 9afcfb2 Compare November 24, 2017 07:38

0xc0170 approved these changes Nov 24, 2017

View reviewed changes

0xc0170 added needs: work and removed needs: CI labels Nov 27, 2017

mprse force-pushed the feature-hal-spec-sleep_tests branch from 4e23237 to 1ca3b24 Compare January 12, 2018 06:50

mprse force-pushed the feature-hal-spec-sleep_tests branch from 1ca3b24 to 72aa953 Compare January 15, 2018 10:09

mprse force-pushed the feature-hal-spec-sleep_tests branch from 72aa953 to 7ee9b0e Compare January 15, 2018 10:25

0xc0170 removed needs: preceding PR needs: work labels Jan 16, 2018

0xc0170 approved these changes Jan 16, 2018

View reviewed changes

0xc0170 added the ready for merge label Jan 16, 2018

0xc0170 merged commit e81d4f1 into ARMmbed:feature-hal-spec-sleep Jan 16, 2018

0xc0170 removed the ready for merge label Jan 16, 2018

Add tests for Sleep HAL API #5509

Add tests for Sleep HAL API #5509

Uh oh!

Conversation

mprse commented Nov 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Status

Migrations

Related PRs

Todos

Uh oh!

bulislaw left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mprse Nov 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bulislaw commented Nov 21, 2017

Uh oh!

mprse commented Nov 22, 2017

Uh oh!

0xc0170 commented Nov 22, 2017

Uh oh!

mbed-ci commented Nov 22, 2017

Uh oh!

mprse commented Nov 22, 2017

Uh oh!

bulislaw commented Nov 23, 2017

Uh oh!

mbed-ci commented Nov 23, 2017

Uh oh!

bulislaw commented Nov 23, 2017

Uh oh!

mprse commented Nov 24, 2017

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Nov 24, 2017

Uh oh!

mprse commented Nov 24, 2017

Uh oh!

mbed-ci commented Nov 24, 2017

Triggering tests

Uh oh!

mbed-ci commented Nov 24, 2017

Uh oh!

mbed-ci commented Nov 24, 2017

Uh oh!

0xc0170 commented Nov 24, 2017

Uh oh!

mprse commented Nov 24, 2017

Uh oh!

mprse commented Nov 24, 2017

Uh oh!

bulislaw commented Nov 27, 2017

Uh oh!

mbed-ci commented Jan 11, 2018

Uh oh!

0xc0170 commented Jan 11, 2018

Uh oh!

mbed-ci commented Jan 11, 2018

Uh oh!

mprse commented Jan 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Jan 12, 2018

Uh oh!

mbed-ci commented Jan 12, 2018

Triggering tests

Uh oh!

mbed-ci commented Jan 12, 2018

Uh oh!

mbed-ci commented Jan 12, 2018

mprse commented Nov 16, 2017 •

edited

Loading

mprse Nov 22, 2017 •

edited

Loading

mprse commented Jan 12, 2018 •

edited

Loading