RTL8195AM - refactor bootloader and fota support #5531

tung7970 · 2017-11-20T07:26:33Z

Description

Refactor bootloader and fota support.

redefine OTA flash regions

OTA regions are moved to 0x040000 and 0x120000 to make room for mbed credentials and settings.

redefine bootloader headers

Headers are redefined for better integration with mbed cloud FOTA services.

Status

READY

Migrations

NONE

Related PRs

NONE

Todos

NONE

Deploy notes

NONE

Steps to test or reproduce

NONE

marcuschangarm · 2017-11-20T16:15:46Z

targets/TARGET_Realtek/TARGET_AMEBA/ota_api.h

+#define OTA_TAG_OFS         0x0
+#define OTA_VER_OFS         0x4
+#define OTA_EPOCH_OFS       0x8
+#define OTA_SIZE_OFS        0xf


Shouldn't the size offset be 0x10?

Yeap. It should be 0x10. Thanks.

marcuschangarm · 2017-11-20T16:32:44Z

@tung7970

I'm unable to boot up. This is the error I'm getting:

Image1 Validate OK, Going jump to Image1
BOOT from Flash:YES
SPI calibration
Find the avaiable window
SDR Controller Init:0; Delay start:0; Delay end:63
Test 0: No match addr 0xc9d38 => 0xf != 0xc
Test 0: No match addr 0x1f7c10 => 0x5 != 0xe
ram2: crc32 4d32fd02 <==> f3fc3585
ram2: crc32 9be76dba <==> aceefcf9
Unable to boot image 2

tung7970 · 2017-11-21T04:01:35Z

@marcuschangarm Hi, updated bootloader. Please give it a try. Thanks.

marcuschangarm · 2017-11-21T16:26:10Z

@tung7970 It works now! We are back in business!

0xc0170 · 2017-11-22T11:07:23Z

/morph build

mbed-ci · 2017-11-22T11:40:44Z

Build : FAILURE

Build number : 571
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5531/

kegilbert · 2017-11-22T18:36:33Z

When running locally looks like a string is being passed in the number argument to format_number causing the

line = format(number, '0%dx' % (width))
ValueError: Unknown format code 'x' for object of type 'str'

error.

Specifically the RAM2_HEADER tag and ver fields look like junk when running on the event_flags test for example.

@marcuschangarm

marcuschangarm · 2017-11-22T18:55:47Z

I don't understand why not all of the compilations are failing. In the trace output, most of the binaries are created correctly.

What command are you using? When I build locally it works:

mbed test --compile -m REALTEK_RTL8195AM -t GCC_ARM

kegilbert · 2017-11-22T19:08:41Z

Running the same command I can reproduce the error on the CI test node and on a local Linux machine both running Python 2.7.12.

That's really strange, I'm honestly not sure why only certain builds cause it. It doesn't seem to happen to the same binaries each time.

marcuschangarm · 2017-11-22T19:14:39Z

https://bugs.launchpad.net/ubuntu/+source/file/+bug/248619

0xc0170 · 2017-11-24T13:04:41Z

/morph build

mbed-ci · 2017-11-24T14:31:31Z

Build : SUCCESS

Build number : 592
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5531/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2017-11-24T17:58:09Z

Exporter Build : SUCCESS

Build number : 204
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5531/

mbed-ci · 2017-11-24T23:35:05Z

Test : SUCCESS

Build number : 405
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5531/405

marcuschangarm · 2017-11-28T00:39:17Z

Can we get this in before the freeze, please? 😄

0xc0170 · 2017-11-28T11:13:38Z

Can we get this in before the freeze, please? 😄

Waiting for review from @theotherjimmy (tools changes)

0xc0170

The print might be removed, the rest LGTM

0xc0170 · 2017-11-28T11:15:17Z

targets/TARGET_Realtek/TARGET_AMEBA/ota_api.c

        return 0;
    }

-    printf("OTA: read addr=0x%lx\r\n", addr);
-    return flash_ext_stream_read(&flash_obj, addr, len, data);
+    printf("OTA: read addr=0x%lx\r\n", start);


is this debug print? Should not print always?

Preparing for bootloader redesign. Signed-off-by: Tony Wu <[email protected]>

1. move ota region 1 from 0x00b000 to 0x040000 2. move ota region 2 from 0x0c0000 to 0x120000 3. refactor bootloader header as follows: uint32_t tag; uint32_t ver; uint64_t timestamp; uint32_t size; uint8_t hash[32]; uint8_t campaign[16]; uint32_t crc32; where, a. hash is the sha256 checksum of the payload. b. crc32 is the crc32 checksum of headers from tag to campaign. 4. Call NVIC_SystemReset for soft reset. Signed-off-by: Tony Wu <[email protected]>

tung7970 · 2017-11-28T13:35:25Z

@0xc0170 Done.

0xc0170 · 2017-11-28T14:00:27Z

/morph build

mbed-ci · 2017-11-28T15:27:20Z

Build : SUCCESS

Build number : 614
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5531/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2017-11-28T17:08:21Z

Test : SUCCESS

Build number : 434
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5531/434

mbed-ci · 2017-11-28T19:08:26Z

Exporter Build : SUCCESS

Build number : 231
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5531/

theotherjimmy · 2017-11-28T19:25:04Z

Before I approve this, @tung7970 Are the tools changes backwards compatible? That is, If I were to use the tools directory to compile, say, Mbed OS 5.5.7, would it work?

tung7970 · 2017-11-29T00:19:52Z

@theotherjimmy Yes. This commit is atomic, as long as python script and bootloader bin are used together.

theotherjimmy

Thanks. Be aware this this will upgrade all website builds to the new bootloader when the tools on the website are upgraded. This includes older releases of Mbed OS.

0xc0170 requested review from theotherjimmy and marcuschangarm November 20, 2017 11:19

0xc0170 added the needs: review label Nov 20, 2017

marcuschangarm reviewed Nov 20, 2017

View reviewed changes

tung7970 force-pushed the feature-fota branch 2 times, most recently from e36f9a3 to d1d31c7 Compare November 21, 2017 03:41

tung7970 force-pushed the feature-fota branch from d1d31c7 to c026b7f Compare November 23, 2017 05:48

0xc0170 requested changes Nov 28, 2017

View reviewed changes

tung7970 added 2 commits November 28, 2017 21:29

rtl8195am - cleanup post-processing binary hook

985c2b0

Preparing for bootloader redesign. Signed-off-by: Tony Wu <[email protected]>

tung7970 force-pushed the feature-fota branch from c026b7f to a4575a9 Compare November 28, 2017 13:34

0xc0170 approved these changes Nov 28, 2017

View reviewed changes

theotherjimmy approved these changes Nov 29, 2017

View reviewed changes

theotherjimmy added ready for merge release-version: 5.6.6 and removed needs: review labels Nov 29, 2017

0xc0170 merged commit e413350 into ARMmbed:master Nov 30, 2017

0xc0170 removed the ready for merge label Nov 30, 2017

RTL8195AM - refactor bootloader and fota support #5531

RTL8195AM - refactor bootloader and fota support #5531

Uh oh!

Conversation

tung7970 commented Nov 20, 2017

Description

Status

Migrations

Related PRs

Todos

Deploy notes

Steps to test or reproduce

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marcuschangarm commented Nov 20, 2017

Uh oh!

tung7970 commented Nov 21, 2017

Uh oh!

marcuschangarm commented Nov 21, 2017

Uh oh!

0xc0170 commented Nov 22, 2017

Uh oh!

mbed-ci commented Nov 22, 2017

Uh oh!

kegilbert commented Nov 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marcuschangarm commented Nov 22, 2017

Uh oh!

kegilbert commented Nov 22, 2017

Uh oh!

marcuschangarm commented Nov 22, 2017

Uh oh!

0xc0170 commented Nov 24, 2017

Uh oh!

mbed-ci commented Nov 24, 2017

Triggering tests

Uh oh!

mbed-ci commented Nov 24, 2017

Uh oh!

mbed-ci commented Nov 24, 2017

Uh oh!

marcuschangarm commented Nov 28, 2017

Uh oh!

0xc0170 commented Nov 28, 2017

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tung7970 commented Nov 28, 2017

Uh oh!

0xc0170 commented Nov 28, 2017

Uh oh!

mbed-ci commented Nov 28, 2017

Triggering tests

Uh oh!

mbed-ci commented Nov 28, 2017

Uh oh!

mbed-ci commented Nov 28, 2017

Uh oh!

theotherjimmy commented Nov 28, 2017

Uh oh!

tung7970 commented Nov 29, 2017

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kegilbert commented Nov 22, 2017 •

edited

Loading