Exporter for Netbeans GCC_ARM #5532

cmens23 · 2017-11-20T09:18:59Z

Description

Added a Netbeans Exporter which creates following items:

nbproject Directory
nbproject/configurations.xml
nbproject/project.xml
./.mbedignore (which contains the nbproject Folder)
./Makefile (Netbeans Makefile)

Status

READY

Linking works and is using the Linker Script
Code Assistance works with one exclusion in mbed-os/rtos/TARGET_CORTEX/rtx5/core_cm.h -> Line 57: #error "Unknown ARM Architecture!"

Migrations

File __init__.py in mbed-os\tools\export is modified and has a new configuration:

netbeans

Related PRs

NONE

Todos

Tests
Documentation

Deploy notes

NONE

Steps to test or reproduce

Execute following command to get a Netbeans Project:
mbed-cli export -i netbeans

…e linking still not works

theotherjimmy

Minor nit.

theotherjimmy · 2017-11-27T17:04:44Z

tools/export/nb/__init__.py

@@ -207,11 +211,19 @@ def create_jinja_ctx(self):
        sources = [self.filter_dot(field) for field in sources]
        include_paths = [self.filter_dot(field) for field in self.resources.inc_dirs]

+        sys_libs = [self.prepare_sys_lib(lib) for lib
+                    in self.toolchain.sys_libs]
+        preproc = " ".join([part for part


You don't need this list comprehension. Could you remove it?

Sorry, I don't understand. Could you please more specific?

preproc = " ".join([part for part in ([basename(self.toolchain.preproc[0])] + self.toolchain.preproc[1:] + self.toolchain.ld[1:])])

==

preproc = " ".join([basename(self.toolchain.preproc[0])] + self.toolchain.preproc[1:] + self.toolchain.ld[1:])

theotherjimmy · 2017-11-27T17:06:32Z

@cmens23 Why did you add your own Makefile exporter? could you have imported a Makefile exporter from the makefile module and inherited from that instead?

theotherjimmy

More nits. I apparently only reviewed the last commit last time. huh.

theotherjimmy · 2017-11-27T17:08:10Z

tools/export/nb/__init__.py

+    def prepare_sys_lib(libname):
+        return "-l" + libname
+
+    def toolchain_flags(self, toolchain):


This is the same as the Exporter.flags attribute. Is there some reason that you could not use that?

Well, I just done this, because in 'tools/exporter/gnuarmeclipse/__init.py' it is the same: https://github.com/cmens23/mbed-os/blob/e423947af35a024abdf12cdadce077810cf52398/tools/export/gnuarmeclipse/__init__.py#L78

theotherjimmy · 2017-11-27T17:09:27Z

tools/export/nb/__init__.py

+    def generate(self):
+        """Generate Makefile, configurations.xml & project.xml Netbeans project file
+        """
+        # super(Netbeans, self).generate()


Could you remove this commented out code?

theotherjimmy · 2017-11-27T17:10:01Z

tools/export/nb/__init__.py

+
+        # profile_names = [basename(fn).replace(".json", "")
+        #                 for fn in file_names]
+        # print profile_names


Could you remove commented out code? (5 lines)

theotherjimmy · 2017-11-27T17:15:58Z

tools/export/nb/__init__.py

+            prev_dir = cur_dir
+            output.append('<itemPath>' + str(item) + '</itemPath>')
+            # if last iteration close all open tags
+            if idx == len(file_list) - 1 and cur_dir != '':


I have a refactor proposal:
Remove the enumerate from the loop, move dir_depth out of the loop and close all open tags after the loop. I think that may make for clearer code. For example:

for item in file_list: ... last_dir_len = len(os.path.dirname(file_list[-1]).split(os.path.sep)) output.append('</logicalFolder>' * last_dir_len) return output

theotherjimmy · 2017-11-27T17:17:50Z

@cmens23 I'm excited to see net beans become an Mbed OS exporter! Please let me know if I can help with the porting effort.

…learer code

adbridge · 2017-12-29T14:07:47Z

@theotherjimmy Are you happy with the rework ?

mbed-ci · 2017-12-29T14:07:49Z

Automatic CI verification build not done, please verify manually.

theotherjimmy · 2018-01-02T20:52:40Z

tools/export/nb/__init__.py

+        c_sources = [self.filter_dot(field) for field in getattr(self.resources, 'c_sources')]
+        cpp_sources = [self.filter_dot(field) for field in getattr(self.resources, 'cpp_sources')]
+        s_sources = [self.filter_dot(field) for field in getattr(self.resources, 's_sources')]
+        headers = [self.filter_dot(field) for field in getattr(self.resources, 'headers')]


Please don't use getattr when you don't need to. It can make the code much harder to follow. This applies to the preceding 4 lines.

theotherjimmy · 2018-01-02T21:11:32Z

tools/export/nb/__init__.py

+        sys_libs = [self.prepare_sys_lib(lib) for lib
+                    in self.toolchain.sys_libs]
+        preproc = " ".join([basename(self.toolchain.preproc[0])] +
+                                self.toolchain.preproc[1:] +


This indentation looks off. I think the s in self should line up with the [ in the previous line.

…y brackets

cmonr · 2018-01-12T17:28:37Z

@theotherjimmy Thoughts on the latest commits?

theotherjimmy

Looks good! Thanks for the exporter.

theotherjimmy · 2018-01-12T19:54:49Z

@cmens23 If there is a method to build an exported project from the command line, we can put this in our CI to prevent subsequent PRs from breaking this exporter.

cmonr · 2018-01-12T20:44:36Z

/morph build

0xc0170 · 2018-01-15T06:53:12Z

/morph build

mbed-ci · 2018-01-15T07:29:58Z

Build : SUCCESS

Build number : 862
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5532/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-15T08:32:39Z

Exporter Build : SUCCESS

Build number : 533
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5532/

…n of jinja

MikeDK · 2018-01-15T11:23:13Z

@theotherjimmy regarding your question about a method to build from command line...: unfortunately, the needed sub-makefiles are only generated if one starts a build from within the netbeans IDE at least once. From this time on, the sub-makefiles are present in the nbproject directory, and one can issue a simple "make" from the project root.

In MPLAB-X, which is basically a microchip-specific fork of netbeans, there is a .jar file which does exactly what we would need: generate the sub-makefiles from the command line ... but unfortunately this looks like something microchip did only for their MPLAB-X IDE ... I cannot find similar tool in vanilla netbeans :(

mbed-ci · 2018-01-15T11:31:36Z

Test : SUCCESS

Build number : 708
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5532/708

0xc0170 · 2018-01-15T15:20:26Z

/morph build

mbed-ci · 2018-01-15T15:45:08Z

Build : SUCCESS

Build number : 868
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5532/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-15T17:38:47Z

Exporter Build : SUCCESS

Build number : 540
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5532/

mbed-ci · 2018-01-15T19:42:55Z

Test : SUCCESS

Build number : 716
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5532/716

c.mandl added 2 commits November 20, 2017 10:02

Added Netbeans Exporter

1b30df9

Removed commented Line

8e23b80

0xc0170 requested a review from theotherjimmy November 20, 2017 11:11

0xc0170 added the needs: review label Nov 20, 2017

Refactoring of Netbeans Exporter...still some more work to do, becaus…

b112ad7

…e linking still not works

cmens23 changed the title ~~Exporter for Netbeans~~ Exporter for Netbeans GCC_ARM Nov 24, 2017

Fixed Linking with Linker Script

e423947

theotherjimmy suggested changes Nov 27, 2017

View reviewed changes

Clemens Mandl added 4 commits November 28, 2017 07:14

Removed commented Line

2843c9f

Removed another block of unused (commented) code

61461bc

Refactoring of function get_netbeans_file_list(file_list) to have a c…

52839aa

…learer code

Removed unnecessary list comprehension

ff7d723

theotherjimmy suggested changes Jan 8, 2018

View reviewed changes

Clemens Mandl added 3 commits January 9, 2018 15:57

Fixed indention in Line 217 and 218

fe3f533

Removed getattr() where it was not needed

212e566

Small Refactoring of variable definitions and removed some unnecessar…

a070327

…y brackets

theotherjimmy approved these changes Jan 12, 2018

View reviewed changes

cmonr added needs: CI and removed needs: review labels Jan 12, 2018

Added Compiler Toolchain Varibales in Templates and modfied generatio…

b741e85

…n of jinja

cmonr added the release-version: 5.7.4 label Jan 22, 2018

cmonr merged commit c2784c8 into ARMmbed:master Jan 22, 2018

cmonr removed the needs: CI label Jan 22, 2018

Exporter for Netbeans GCC_ARM #5532

Exporter for Netbeans GCC_ARM #5532

Uh oh!

Conversation

cmens23 commented Nov 20, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Status

Migrations

Related PRs

Todos

Deploy notes

Steps to test or reproduce

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theotherjimmy Nov 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theotherjimmy commented Nov 27, 2017

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theotherjimmy commented Nov 27, 2017

Uh oh!

adbridge commented Dec 29, 2017

Uh oh!

mbed-ci commented Dec 29, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmonr commented Jan 12, 2018

Uh oh!

theotherjimmy left a comment

Choose a reason for hiding this comment

Uh oh!

theotherjimmy commented Jan 12, 2018

Uh oh!

cmonr commented Jan 12, 2018

Uh oh!

0xc0170 commented Jan 15, 2018

Uh oh!

mbed-ci commented Jan 15, 2018

Triggering tests

Uh oh!

mbed-ci commented Jan 15, 2018

Uh oh!

MikeDK commented Jan 15, 2018

Uh oh!

mbed-ci commented Jan 15, 2018

Uh oh!

0xc0170 commented Jan 15, 2018

Uh oh!

cmens23 commented Nov 20, 2017 •

edited

Loading

theotherjimmy Nov 28, 2017 •

edited

Loading