M487: Fix premature lp_ticker interrupt #5552
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old lp_ticker handles past event, but it has a bug with premature go-off. The bug can re-produce on mbed-os-tests-mbed_drivers-lp_timeout/mbed-os-tests-mbed_hal-lp_us_tickers (mbed-os commit: 9c1fd48). Because upper layer (mbed-os/hal/mbed_ticker_api.c) has handled past event, this code can be removed from lp_ticker. The similar fix also applies to us_ticker.
|
Travis still fails to report, when I check https://travis-ci.org/OpenNuvoton, it fails to find any, but @ccli8 is there in the travis database so should work as indicated earlier by their support. I am going to resend this from my fork, that will trigger travis 😕 I emailed to the support again that their proposal fails (you on the copy so should see the msg). |
|
It is already integrated: #5553 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes premature lp_ticker interrupt issue on NUMAKER_PFM_M487 target.
Related PRs
#5366
This PR is the resend of the above due to abuse flag issue on travis CI.