Ethernet tests update #5576

jeromecoutant · 2017-11-24T10:21:21Z

Description

Some tests have been updated:

tests-netsocket-gethostbyname:

MBED_DNS_TEST_HOST define is replaced by MBED_CONF_APP_DNS_TEST_HOST to allow user to change host name for local tests

tests-netsocket-udp_echo:

UUID lines are removed as they were not used
If MBED_CONF_APP_ECHO_SERVER_ADDR and MBED_CONF_APP_ECHO_SERVER_PORT are not defined (default case), test is using Greentea to get server information (code before OS 5.6.1 version)

tests-netsocket-tcp_echo:

UUID lines are removed as they were not used
If MBED_CONF_APP_ECHO_SERVER_ADDR and MBED_CONF_APP_ECHO_SERVER_PORT are not defined (default case), test is using Greentea to get server information (code before OS 5.6.1 version)
TCP_ECHO_PREFIX is no more a mandatory feature

tests-netsocket-tcp_hello_world:

HTTP_SERVER_NAME and HTTP_SERVER_FILE_PATH are replaced by MBED_CONF_APP_HTTP_SERVER_NAME and MBED_CONF_APP_HTTP_SERVER_FILE_PATH to allow user to make local tests

Status

READY

jeromecoutant · 2017-11-24T12:12:23Z

Added update for tests-netsocket-socket_sigio,
as test was always OK even with no connection!

jeromecoutant · 2017-11-28T13:02:52Z

@SeppoTakalo @sarahmarshy
Any update ?
Thx

sarahmarshy · 2017-11-28T13:15:31Z

I'll get to this tomorrow. I've been out on holiday, and in travelling home today. One immediate question: why did you remove part of the EthernetInterface config? That is what most targets use if they have LWIP, so you'll leave a lot undefined.

@geky can also review

sarahmarshy · 2017-11-29T16:55:35Z

TESTS/netsocket/socket_sigio/main.cpp

@@ -122,10 +126,13 @@ void test_socket_attach() {
        sock.send(buffer, strlen(buffer));
        // wait for recv data
        recvd.wait();
+
+        result = true;


as test was always OK even with no connection!

That should not be the case -- this line will attach the get_data function. If get_data never gets called because of an incorrect implementation of sigio, this test case will time out. If get_data does get called, the success of the test depends on the getting some data from the server here

No...
With my local test env, test was always OK whereas it is not possible to connect ARM server....

sarahmarshy · 2017-11-29T16:58:20Z

tools/test_configs/EthernetInterface.json

@@ -10,18 +10,6 @@
        "connect-statement" : {
            "help" : "Must use 'net' variable name",
            "value" : "((EthernetInterface *)net)->connect()"
-        },


These changes will cause mbed OS tests to fail. I believe this should continue to be the default test configuration file. If echo server changes are necessary, then that person should use a custom test configuration file and specify it with the --test-config option.

No...
Check the updates in test c files. You can keep these setting in your files, there will be no change for you.
If user doesn't want to set manually the settings and use greentea feature, it is now possible

Yes. By default, LWIP targets use this file. The echo server is not set to ublox echo server in this file, nor in the cpp files.

Change your test setup...
Default configuration should be the basic configuration without any specific setting.
If you have a specific test environment, use a specific json configuration file.

By and large, the Ublox server will be accessible on a network. It is a special case that is is not accessible. We want to provide a sensible default, and it is, unless you have a special case.

MBED_DNS_TEST_HOST define is replaced by MBED_CONF_APP_DNS_TEST_HOST to allow user to change host name for local tests

UUID lines are removed as they were not used default case: If MBED_CONF_APP_ECHO_SERVER_ADDR and MBED_CONF_APP_ECHO_SERVER_PORT are not defined test is using Greentea to get server information (code before OS 5.6.1 version)

UUID lines are removed as they were not used default case: If MBED_CONF_APP_ECHO_SERVER_ADDR and MBED_CONF_APP_ECHO_SERVER_PORT are not defined test is using Greentea to get server information (code before OS 5.6.1 version) TCP_ECHO_PREFIX is no more a mandatory step

HTTP_SERVER_NAME and HTTP_SERVER_FILE_PATH are replaced by MBED_CONF_APP_HTTP_SERVER_NAME and MBED_CONF_APP_HTTP_SERVER_FILE_PATH to allow user to make local tests

HTTP_SERVER_NAME and HTTP_SERVER_FILE_PATH are replaced by MBED_CONF_APP_HTTP_SERVER_NAME and MBED_CONF_APP_HTTP_SERVER_FILE_PATH to allow user to make local tests Test on HTTP connect added as test was always OK even with no connection...

jeromecoutant · 2017-12-04T16:58:28Z

Hi @sarahmarshy

json files updates removed and rebase done
There should be no change in your test env, and it's OK in my local test env.

Regards

sarahmarshy · 2017-12-04T17:05:39Z

/morph test

mbed-ci · 2017-12-04T17:26:49Z

Test : FAILURE

Build number : 471
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5576/471

kegilbert · 2017-12-04T17:34:09Z

/morph build

mbed-ci · 2017-12-04T18:31:53Z

Build : SUCCESS

Build number : 650
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5576/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2017-12-04T20:01:55Z

Test : SUCCESS

Build number : 473
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5576/473

mbed-ci · 2017-12-04T20:42:56Z

Exporter Build : SUCCESS

Build number : 289
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5576/

0xc0170 · 2017-12-05T16:40:34Z

Thanks @sarahmarshy , I assume you are happy with as it is now.

@SeppoTakalo Please can you review this PR

0xc0170 · 2017-12-07T16:03:11Z

Just to be certain

/morph test

mbed-ci · 2017-12-07T18:24:13Z

Test : SUCCESS

Build number : 492
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5576/492

jeromecoutant mentioned this pull request Nov 24, 2017

Fix for configurable network driver tests #5335

Merged

0xc0170 added the needs: review label Nov 24, 2017

0xc0170 requested review from SeppoTakalo and sarahmarshy November 24, 2017 11:56

sarahmarshy reviewed Nov 29, 2017

View reviewed changes

jeromecoutant added 5 commits December 4, 2017 17:55

tests-netsocket-gethostbyname

61b8468

MBED_DNS_TEST_HOST define is replaced by MBED_CONF_APP_DNS_TEST_HOST to allow user to change host name for local tests

tests-netsocket-udp_echo

3cb8316

UUID lines are removed as they were not used default case: If MBED_CONF_APP_ECHO_SERVER_ADDR and MBED_CONF_APP_ECHO_SERVER_PORT are not defined test is using Greentea to get server information (code before OS 5.6.1 version)

tests-netsocket-tcp_hello_world

bff8fc1

HTTP_SERVER_NAME and HTTP_SERVER_FILE_PATH are replaced by MBED_CONF_APP_HTTP_SERVER_NAME and MBED_CONF_APP_HTTP_SERVER_FILE_PATH to allow user to make local tests

tests-netsocket-socket_sigio

d8cc5a3

HTTP_SERVER_NAME and HTTP_SERVER_FILE_PATH are replaced by MBED_CONF_APP_HTTP_SERVER_NAME and MBED_CONF_APP_HTTP_SERVER_FILE_PATH to allow user to make local tests Test on HTTP connect added as test was always OK even with no connection...

jeromecoutant force-pushed the PR_IP branch from ccd1797 to d8cc5a3 Compare December 4, 2017 16:55

SeppoTakalo approved these changes Dec 7, 2017

View reviewed changes

0xc0170 added ready for merge and removed needs: review labels Dec 7, 2017

jeromecoutant mentioned this pull request Dec 7, 2017

gethostbyname test FAIL with NUCLEO_F746ZG and IAR #5622

Closed

jeromecoutant mentioned this pull request Dec 12, 2017

Fixes NUCLEO_F746ZG gethostbyname test compiled with IAR #5689

Closed

0xc0170 added the release-version: 5.7.1 label Dec 12, 2017

0xc0170 merged commit 57a5735 into ARMmbed:master Dec 12, 2017

0xc0170 removed the ready for merge label Dec 12, 2017

jeromecoutant deleted the PR_IP branch December 13, 2017 08:54

Ethernet tests update #5576

Ethernet tests update #5576

Uh oh!

Conversation

jeromecoutant commented Nov 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Status

Uh oh!

jeromecoutant commented Nov 24, 2017

Uh oh!

jeromecoutant commented Nov 28, 2017

Uh oh!

sarahmarshy commented Nov 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeromecoutant Nov 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sarahmarshy Nov 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeromecoutant commented Dec 4, 2017

Uh oh!

sarahmarshy commented Dec 4, 2017

Uh oh!

mbed-ci commented Dec 4, 2017

Uh oh!

kegilbert commented Dec 4, 2017

Uh oh!

mbed-ci commented Dec 4, 2017

Triggering tests

Uh oh!

mbed-ci commented Dec 4, 2017

Uh oh!

mbed-ci commented Dec 4, 2017

Uh oh!

0xc0170 commented Dec 5, 2017

Uh oh!

0xc0170 commented Dec 7, 2017

Uh oh!

mbed-ci commented Dec 7, 2017

Uh oh!

Uh oh!

jeromecoutant commented Nov 24, 2017 •

edited

Loading

jeromecoutant Nov 30, 2017 •

edited

Loading

sarahmarshy Nov 30, 2017 •

edited

Loading