Skip to content

REALTEK_RTL8195AM Wifi driver - adds check of credentials validity #5577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2017
Merged

REALTEK_RTL8195AM Wifi driver - adds check of credentials validity #5577

merged 1 commit into from
Dec 12, 2017

Conversation

VeijoPesonen
Copy link
Contributor

Adds checks that SSID is non-empty and that password is 8-63 characters
long when security is enabled

Description

Enables checking of SSID and password validity when set_credentials() is called

Status

READY

Migrations

NO

Steps to test or reproduce

...\mbed-os> mbed test --compile -t ARM -m REALTEK_RTL8195AM --app-config .\TESTS\network\wifi\template_mbed_app.txt -n tests-network-wifi
...\mbed-os> mbedhtrun -f .\BUILD\tests\REALTEK_RTL8195AM\ARM\TESTS\network\wifi\wifi.bin -d X: -p COMY:9600

REALTEK_RTL8195AM Wifi driver - adds check of credentials
ee77079 
Adds checks that SSID is non-empty and that password is 8-63 characters
long when security is enabled
@VeijoPesonen
Copy link
Contributor Author

@SeppoTakalo , @jarlamsa , @mikaleppanen , please review

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 24, 2017

cc @ARMmbed/team-realtek

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 30, 2017

@ARMmbed/team-realtek Are you happy with this patch?

@Archcady
Copy link
Contributor

Archcady commented Dec 1, 2017

Yes, this patch seems reasonable.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 1, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Dec 1, 2017

Build : SUCCESS

Build number : 637
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5577/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 1, 2017

Test : SUCCESS

Build number : 462
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5577/462

@mbed-ci
Copy link

mbed-ci commented Dec 1, 2017

Exporter Build : FAILURE

Build number : 267
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5577/

@mbed-ci
Copy link

mbed-ci commented Dec 1, 2017

Test : SUCCESS

Build number : 465
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5577/465

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2017

Restarting due to CI error

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 5, 2017

Exporter Build : SUCCESS

Build number : 295
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5577/

@0xc0170 0xc0170 merged commit aff1d30 into ARMmbed:master Dec 12, 2017
@VeijoPesonen VeijoPesonen deleted the realtek_rtl8195am_gt_wifi-set-credential branch December 13, 2017 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@tung7970 tung7970 tung7970 approved these changes

@mikaleppanen mikaleppanen mikaleppanen approved these changes

@Archcady Archcady Archcady approved these changes

@jarlamsa jarlamsa jarlamsa approved these changes

Assignees
No one assigned
Labels
release-version: 5.7.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@VeijoPesonen @0xc0170 @Archcady @mbed-ci @SeppoTakalo @tung7970 @mikaleppanen @jarlamsa