-
Notifications
You must be signed in to change notification settings - Fork 3k
Upgrade to Silicon Labs HAL #5584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph build |
Build : SUCCESSBuild number : 601 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 213 |
/morph uvisor-test |
Thanks for enabling the other USART's @stevew817 .. |
Test : SUCCESSBuild number : 418 |
@alzix Can you please look at the failure for EFM32GG_STK3700 in uvisor? It seems it sync error. Might be related to this patch . |
@orenc17A ^ the above |
@0xc0170 does this PR requires a new bootloader on the EFM32 platforms? |
@0xc0170 I don't have access to the output of the uVisor CI. Could you tell me what is failing? |
@orenc17A is currently looking , will provide more details |
@stevew817 does the PR changes things in the memory layout? |
@@ -61,29 +60,23 @@ void SYSTEM_ChipRevisionGet(SYSTEM_ChipRevision_TypeDef *rev) | |||
uint8_t tmp; | |||
|
|||
EFM_ASSERT(rev); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0xc0170 this is the problematic code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it that SECURE_READ was used, and now being replaced by just direct access? @stevew817 Please can you review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah damn, forgot to cherrypick the uvisor-specific path to that file. Will fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stevew817 have you added the uvisor-specific commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, added just now.
To allow enabling of uVisor on EFM32, the ROM table must be accessed through the CMSIS-provided SECURE_ACCESS macro.
/morph build |
Build : SUCCESSBuild number : 624 Triggering tests/morph test |
Test : SUCCESSBuild number : 446 |
Exporter Build : SUCCESSBuild number : 251 |
@stevew817 All fixed, should be good to go |
@0xc0170 Thanks, looking forward! |
Description
Upgrades the version of emlib in mbed to v5.3.3. Additionally enables the use of USART3, USART4 and USART5 for both serial and SPI (important for using TB_SENSE_12's IMU, CC @ashok-rao )
Also cleans up various warnings emitted when compiling for Silicon Labs targets.
Status
READY