Skip to content

Upgrade to Silicon Labs HAL #5584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 30, 2017
Merged

Conversation

stevew817
Copy link
Contributor

@stevew817 stevew817 commented Nov 24, 2017

Description

Upgrades the version of emlib in mbed to v5.3.3. Additionally enables the use of USART3, USART4 and USART5 for both serial and SPI (important for using TB_SENSE_12's IMU, CC @ashok-rao )

Also cleans up various warnings emitted when compiling for Silicon Labs targets.

Status

READY

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 27, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 27, 2017

Build : SUCCESS

Build number : 601
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5584/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Nov 27, 2017

@theotherjimmy
Copy link
Contributor

/morph uvisor-test

@ashok-rao
Copy link
Contributor

Thanks for enabling the other USART's @stevew817 ..

@mbed-ci
Copy link

mbed-ci commented Nov 27, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 28, 2017

@alzix Can you please look at the failure for EFM32GG_STK3700 in uvisor? It seems it sync error. Might be related to this patch .

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 28, 2017

@orenc17A ^ the above

@orenc17
Copy link
Contributor

orenc17 commented Nov 28, 2017

@0xc0170 does this PR requires a new bootloader on the EFM32 platforms?

@stevew817
Copy link
Contributor Author

@0xc0170 I don't have access to the output of the uVisor CI. Could you tell me what is failing?

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 29, 2017

@orenc17A is currently looking , will provide more details

@orenc17
Copy link
Contributor

orenc17 commented Nov 29, 2017

@stevew817 does the PR changes things in the memory layout?

@@ -61,29 +60,23 @@ void SYSTEM_ChipRevisionGet(SYSTEM_ChipRevision_TypeDef *rev)
uint8_t tmp;

EFM_ASSERT(rev);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170 this is the problematic code

Copy link
Contributor

@0xc0170 0xc0170 Nov 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it that SECURE_READ was used, and now being replaced by just direct access? @stevew817 Please can you review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah damn, forgot to cherrypick the uvisor-specific path to that file. Will fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevew817 have you added the uvisor-specific commit?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, added just now.

To allow enabling of uVisor on EFM32, the ROM table must be accessed
through the CMSIS-provided SECURE_ACCESS macro.
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 30, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 30, 2017

Build : SUCCESS

Build number : 624
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5584/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Nov 30, 2017

@mbed-ci
Copy link

mbed-ci commented Nov 30, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 30, 2017

@stevew817 All fixed, should be good to go

@stevew817
Copy link
Contributor Author

@0xc0170 Thanks, looking forward!

@0xc0170 0xc0170 merged commit 2b84a17 into ARMmbed:master Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants