Protect local static object construction in ARMCC #5635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test for construction of local static objects doesn't check to see if the object returned has been fully initialized. Because of this, an error with ARMCC was not detected. This patch adds an assert to the race_test to ensure that the object has been properly initialized.
|
/morph build |
|
@theotherjimmy does anything special need to be done for ARMC6? |
|
You need to add: #if defined (__ARMCC_VERSION) && (__ARMCC_VERSION >= 6010050)
or similar for armc6 to pick up the block. |
|
@theotherjimmy This is already present: |
|
@c1728p9 Yeah, I saw that. You don't have anything related to |
Implement the functions __cxa_guard_acquire, __cxa_guard_release and __cxa_guard_abort for ARMCC so local static object construction is thread safe.
c1728p9
force-pushed
the
fix_lazy_init
branch
from
9f0d622 to
c63a627
Compare
|
My bad. I updated the PR to add it. |
0xc0170
approved these changes
Dec 1, 2017
|
/morph build |
Build : SUCCESSBuild number : 644 Triggering tests/morph test |
Test : SUCCESSBuild number : 466 |
pan-
approved these changes
Dec 4, 2017
Exporter Build : SUCCESSBuild number : 283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the functions __cxa_guard_acquire, __cxa_guard_release and __cxa_guard_abort for ARMCC so local static object construction is thread safe. Also update the race test to properly detect this bug.