-
Notifications
You must be signed in to change notification settings - Fork 3k
AD: Fix ADC driver #5703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AD: Fix ADC driver #5703
Conversation
@dave-wu Looks fine, could you rework your commit message to the msg you provided here:
This is good guide for how it can look like https://chris.beams.io/posts/git-commit/#seven-rules |
/morph build |
Build : SUCCESSBuild number : 716 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 369 |
Test : FAILUREBuild number : 546 |
/morph test |
Test : SUCCESSBuild number : 547 |
@dave-wu Can you please rebase from latest master please, will fix travis timeout. |
Set buffer for 1 sample in analogin_read_u16. Before it assumes the buffer is set outside by the higher layer. Now it's temporarily located on the stack since only the ADC value is returned.
@0xc0170 Just rebased. |
/morph build |
Build : SUCCESSBuild number : 758 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 411 |
Test : FAILUREBuild number : 589 |
/morph test |
Test : FAILUREBuild number : 599 |
/morph test |
Test : SUCCESSBuild number : 602 |
Description
Status
Ready
Migrations
NO
Related PRs
N/A
branch | PR
N/A
Todos
N/A
Deploy notes
N/A
Steps to test or reproduce
N/A