Skip to content

AD: Fix ADC driver #5703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2018
Merged

AD: Fix ADC driver #5703

merged 1 commit into from
Jan 4, 2018

Conversation

dave-wu
Copy link
Contributor

@dave-wu dave-wu commented Dec 13, 2017

Description

  • Cleared data structures in analogin_init();
  • Set buffer for 1 sample in analogin_read_u16. Before it assumes the buffer is set outside by the higher layer. Now it's temporarily located on the stack since only the ADC value is returned.

Status

Ready

Migrations

NO

Related PRs

N/A

branch | PR

N/A

Todos

N/A

Deploy notes

N/A

Steps to test or reproduce

N/A

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 14, 2017

@dave-wu Looks fine, could you rework your commit message to the msg you provided here:

Cleared data structures in analogin_init();
Set buffer for 1 sample in analogin_read_u16. Before it assumes the buffer is set outside by the higher layer. Now it's temporarily located on the stack since only the ADC value is returned.

This is good guide for how it can look like https://chris.beams.io/posts/git-commit/#seven-rules

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2017

Build : SUCCESS

Build number : 716
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5703/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2017

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2017

/morph test

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 20, 2017

@dave-wu Can you please rebase from latest master please, will fix travis timeout.

Set buffer for 1 sample in analogin_read_u16. Before it assumes the
buffer is set outside by the higher layer. Now it's temporarily
located on the stack since only the ADC value is returned.
@dave-wu
Copy link
Contributor Author

dave-wu commented Dec 20, 2017

@0xc0170 Just rebased.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 22, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Dec 22, 2017

Build : SUCCESS

Build number : 758
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5703/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 22, 2017

@mbed-ci
Copy link

mbed-ci commented Dec 28, 2017

@cmonr
Copy link
Contributor

cmonr commented Dec 28, 2017

/morph test

@mbed-ci
Copy link

mbed-ci commented Dec 29, 2017

@adbridge
Copy link
Contributor

/morph test

@mbed-ci
Copy link

mbed-ci commented Dec 29, 2017

@theotherjimmy theotherjimmy changed the title Some fixes in ADC driver fix ADC driver Jan 4, 2018
@theotherjimmy theotherjimmy changed the title fix ADC driver AD: Fix ADC driver Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants