-
Notifications
You must be signed in to change notification settings - Fork 3k
Remove destruction of WiFi interface in test runs #5723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@SeppoTakalo Can you please rebase from latest master please, will fix travis timeout. |
Isn't this somehow changing the behavior of the tests in the sense that disconnecting - as far as I understand - should/would maintain previously set credentials?!? |
Most of our IP stacks don't allow removal of interfaces so interface destructor can not reliably clean up. Therefore we cannot rely its behaviours in test case. Instead run interface->disconnect() in case interface was already created.
fd11f47
to
8bfe577
Compare
Rebased. @betzw Very valid point. |
/morph build |
Build : FAILUREBuild number : 740 |
/morph build |
Build : SUCCESSBuild number : 755 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 406 |
Test : FAILUREBuild number : 579 |
/morph test |
Test : SUCCESSBuild number : 600 |
Description
Most of our IP stacks don't allow removal of interfaces so
interface destructor can not reliably clean up. Therefore we
cannot rely its behaviours in test case.
Instead run interface->disconnect() in case interface was already
created.
Status
READY
Migrations
NO