Skip to content

Remove destruction of WiFi interface in test runs #5723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2017

Conversation

SeppoTakalo
Copy link
Contributor

Description

Most of our IP stacks don't allow removal of interfaces so
interface destructor can not reliably clean up. Therefore we
cannot rely its behaviours in test case.

Instead run interface->disconnect() in case interface was already
created.

Status

READY

Migrations

NO

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 20, 2017

@SeppoTakalo Can you please rebase from latest master please, will fix travis timeout.

@betzw
Copy link
Contributor

betzw commented Dec 20, 2017

Isn't this somehow changing the behavior of the tests in the sense that disconnecting - as far as I understand - should/would maintain previously set credentials?!?

Most of our IP stacks don't allow removal of interfaces so
interface destructor can not reliably clean up. Therefore we
cannot rely its behaviours in test case.

Instead run interface->disconnect() in case interface was already
created.
@SeppoTakalo
Copy link
Contributor Author

Rebased.

@betzw Very valid point.
The testcase WIFI-CONNECT-NOCREDENTIALS actually depends on the fact that no credentials have been fed to the driver. Therefore I now moved it to be very first test case after a constructor.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 21, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Dec 21, 2017

Build : FAILURE

Build number : 740
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5723/

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 22, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Dec 22, 2017

Build : SUCCESS

Build number : 755
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5723/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 22, 2017

@mbed-ci
Copy link

mbed-ci commented Dec 22, 2017

@cmonr
Copy link
Contributor

cmonr commented Dec 28, 2017

/morph test

@mbed-ci
Copy link

mbed-ci commented Dec 29, 2017

@adbridge adbridge merged commit 2f4f82e into ARMmbed:master Dec 29, 2017
@SeppoTakalo SeppoTakalo deleted the wifi-construtor-fix branch January 2, 2018 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants