-
Notifications
You must be signed in to change notification settings - Fork 3k
Travis: define matrix builds for mbed 2 jobs #5729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b56d27c
to
4439658
Compare
I think I have it now defined as initially intended. We still use matrix, use env to set vendor to run tests for (to avoid duplication, same matrix job just different env, to set up multiple jobs). We were over the limit of 50 minutes. As travis build script runs, its build libs, then links examples. It is the same, just that one job per targets/TARGET_xxxx folder (named vendor in the travis script). The latest job should pass! |
4439658
to
3097e32
Compare
6bb28ee
to
81fe2ed
Compare
Use vendor matrix, creates a job for each vendor folder (targets/TARGET_XXX). This fixes the errors we have seen, as a job has a limit 50 minutes.
Do not fall to default Ruby
81fe2ed
to
e402fdb
Compare
/morph build |
Build : SUCCESSBuild number : 723 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 375 |
Travis fails for Atmel devices, 10 minutes no log, investigating locally |
As we have now matrix for targets, there might be some targets that take longer to compile. It can timeout, if we produce an output after every target that it was build, it should extend the timeout per target build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
.travis.yml
Outdated
@@ -34,6 +34,8 @@ after_success: | |||
after_failure: | |||
- bash -c "$STATUS" failure "Local $NAME testing has failed" | |||
|
|||
language: generic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, should this be python?
.travis.yml
Outdated
|
||
- python: '2.7' | ||
env: | ||
- NAME=mbed2-NUVOTON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I bet there's a way to not have to repeat yourself here... but I tried it on my fork and ran into issues.
Will look into this later...
Still atmel job timeouts. I run it locally takes 460s, run through profiler, multiple times, could not reproduce the timeout (however travis runs multiple jobs (3 at the time)). |
Test : SUCCESSBuild number : 553 |
Looks like it was an issue with gcc-arm-none-eabi version. gcc version 7.1 added Macros containing defined were used heavily in the Atmel HAL. Things exploded to the point where build.py died. This is probably the reason we started seeing the mbed 2 timeouts in the first place. 700f06e Removes the warning. There's not a clear workaround for nested macro defineds and they are pretty entrenched in the Atmel HAL. |
48b8c64
to
253ddfe
Compare
language -> python pip --user installs -> virtual env installs
253ddfe
to
7f9cd50
Compare
/morph build |
I updated the travis file, to specify version (fetch it from official arm website), to stay with GCC ARM 6 as we currently support. For Atmel fix, we will create a new tracking issue wit hthe provided fix here , that needs further investigation. To stay compatible, I reverted that change here (rebased). thanks @geky for the clean-up, looks good ! |
Build : SUCCESSBuild number : 724 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 376 |
Use download from official website, to have fixed version, rather than latest. The official support for current mbed OS is GCC ARM 6.
7f9cd50
to
8cdb2a3
Compare
/morph build |
I found one mistype in yaml file that I fixed, restarting CI, once done this should be ready to get in |
Test : SUCCESSBuild number : 554 |
Build : SUCCESSBuild number : 725 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 377 |
Test : SUCCESSBuild number : 555 |
This is now ready for integration 💯 |
Use matrix for our targets, to get smaller jobs that can run in parallel.