Adding MTB ublox ODIN W2 as a new target. #5740
Conversation
ashok-rao
changed the title
|
|
||
| // MTB Aliases | ||
| // Left side (top view) | ||
| TGT_SWDIO = SWDIO, |
There was a problem hiding this comment.
Can you please fix alignment on the lines below?
There was a problem hiding this comment.
Thanks @0xc0170 . Fixed now!
| } | ||
|
|
||
| (void) HAL_ETH_ConfigMAC(heth, &macconf); | ||
| } |
| @@ -0,0 +1,143 @@ | |||
| #include <string.h> | |||
There was a problem hiding this comment.
this file should contain the license , as the other file does
There was a problem hiding this comment.
Hmm, I didn't find the license information for this file in any other implementation. Will these go under Apache 2.0 itself ? Also, side note, maybe we need to ask vendors for license info on all these implementations?
For example:
- https://github.com/ARMmbed/mbed-os/blob/master/features/FEATURE_LWIP/lwip-interface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_NUCLEO_F439ZI/stm32f4_eth_init.c
- https://github.com/ARMmbed/mbed-os/blob/master/features/FEATURE_LWIP/lwip-interface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_UBLOX_EVK_ODIN_W2/stm32f4_eth_init.c
- https://github.com/ARMmbed/mbed-os/blob/master/features/FEATURE_LWIP/lwip-interface/lwip-eth/arch/TARGET_STM/TARGET_STM32F4/TARGET_MBED_CONNECT_ODIN/stm32f4_eth_init.c
There was a problem hiding this comment.
yes apache would be great.
There was a problem hiding this comment.
Thanks @0xc0170 . Done!
|
@0xc0170 Can you re-review please? |
|
/morph build |
Build : SUCCESSBuild number : 793 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 447 |
Test : SUCCESSBuild number : 628 |
Description
Add ublox ODIN W2 module (MTB / MCB) as a new target.
Status
IN DEVELOPMENT
Todos
Deploy notes
Need addition of new hardware in CI.
cc: @screamerbg @chris-styles @studavekar