Eventloop in main thread #5752
Merged
Eventloop in main thread #5752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjbracey
approved these changes
Dec 21, 2017
SeppoTakalo
approved these changes
Dec 21, 2017
|
Can you please rebase your patch, I rebased the destination branch to get travis fix that is required here |
The separate eventloop thread may not be necessary on all uses, as one can use the existing main thread for event dispatching. Add a conditional nanostack-hal.event-loop-dispatch-from-application, which disables the thread creation. Note: the ns_hal_init must be ran from the same thread which will be used to execute the event loop later.
…read The thread flag signaling mechanism is problematic if a separate event loop thread is not used. The problem is, that one needs to know the thread id of the loop dispathcer, and that knowledge can be derived only from the caller thread of the initialization function. Remove the magic connection from caller thread to dispatcher thread by using event flags instead of thread flags on signaling. As the event flags require the massive amount 20 bytes of RAM whereas thread flags requires none, keep the code behind flag.
TeroJaasko
force-pushed
the
eventloop_in_main_thread
branch
from
f74780f to
9054ef5
Compare
|
Rebased with current feature-miniclient -branch and force pushed. |
SenRamakri
approved these changes
Dec 21, 2017
|
/morph build |
Build : SUCCESSBuild number : 747 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 400 |
Test : SUCCESSBuild number : 572 |
|
@cmonr This didn't need a release version as it is going into a feature branch not master . |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the same content as https://github.com/ARMmbed/mbed-os-confidential-m/pull/7, just the target repo and branch are different.