Skip to content

Fix for #5676 make.py generates duplicate file entries in link_files.txt #5755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2017

Conversation

omdathetkan
Copy link
Contributor

Description

Fix for #5676. In some cases relative_object_path can result in path's like "path\to.\some\file.o", which in turn can result in duplicate file names in the linker list (second entry would be in the form of "path\to\some\file.o")

Status

READY

Migrations

NO

@mbed-ci
Copy link

mbed-ci commented Dec 21, 2017

Automatic CI verification build not done, please verify manually.

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 22, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Dec 22, 2017

Build : SUCCESS

Build number : 749
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5755/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 22, 2017

@mbed-ci
Copy link

mbed-ci commented Dec 22, 2017

@omdathetkan
Copy link
Contributor Author

Can someone tell me why the test failed?

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 22, 2017

Can someone tell me why the test failed?

There's one error for K64F that is known issue, and fix is already proposed. Not related to this changeset

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 22, 2017

The fix was integrated, restarting

/morph test

@mbed-ci
Copy link

mbed-ci commented Dec 28, 2017

@cmonr cmonr merged commit 65dd314 into ARMmbed:master Dec 28, 2017
@cmonr cmonr removed the needs: CI label Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants