Renesas: fix cmsis lib build #5770

0xc0170 · 2017-12-31T08:50:44Z

device header file not needed in cmsis implementation, thus removed - causing problems to build cmsis lib in mbed 2

another fix is for renesas target code that implements os tick, should only be available if rtos is present

Tested locally with GCC ARM

@ARMmbed/team-renesas please verify this patch

0xc0170 · 2017-12-31T08:51:45Z

/morph build

mbed-ci · 2017-12-31T09:22:13Z

Build : FAILURE

Build number : 772
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5770/

0xc0170 · 2017-12-31T16:18:19Z

cmsis/TARGET_CORTEX_A/irq_ctrl_gic.c

@@ -24,8 +24,6 @@

 #include <stddef.h>

-#include <cmsis.h>


Need to fix this, it has real dependency on the target header file (to get gic present macro in), thus I'll look at cmsis build api, and propose a solution)

As this is os tick implementation for rtos, it should not be compilied if rtos not present (mbed 2)

0xc0170 · 2018-01-01T20:16:33Z

/morph build

mbed-ci · 2018-01-01T20:47:33Z

Build : SUCCESS

Build number : 773
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5770/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-01T21:28:04Z

Exporter Build : SUCCESS

Build number : 426
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5770/

mbed-ci · 2018-01-01T21:47:12Z

Test : SUCCESS

Build number : 609
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5770/609

0xc0170 · 2018-01-02T10:35:29Z

I fixed also VK RZ A1H (added to travis to find all those errors there, so both renesas targets are in travis now, should help us).

Waiting for travis, this PR should fix Cortex A mbed 2 errors we have seen. The main change here is cmsis build for mbed 2 (in build_api). cmsis now contains target dependencies in some cases (they include it via RTE components). For instance in our case it was for Cortex A to get GIC presence (see https://github.com/ARMmbed/mbed-os/blob/master/cmsis/TARGET_CORTEX_A/irq_ctrl_gic.c#L31), that one is defined in targets cmsis header file.
To fix this, I moved cmsis lib to be along with hal (previously cmsis, then common headers and hal), how it is common headers, hal + cmsis, etc) in the mbed libs API (the change is minimal, and only affects mbed lib build). The diff is not that obvious here but if you compare those lines you will see that only compile line changed (https://github.com/ARMmbed/mbed-os/pull/5770/files#diff-8ae3dde46b55f3a922724cd3585922b2R1031), the rest there is few lines moved (lines 1002-1014)

adbridge

Minor formatting

adbridge · 2018-01-02T10:45:00Z

tools/build_travis.py

+            {"target": "RZ_A1H",
+             "toolchains": "GCC_ARM",
+             "tests": {""     : ["MBED_2", "MBED_10", "MBED_11", "MBED_16"],
+                       }


NIT: extra space

adbridge · 2018-01-02T10:45:09Z

tools/build_travis.py

+             "toolchains": "GCC_ARM",
+             "tests": {""     : ["MBED_2", "MBED_10", "MBED_11", "MBED_16"],
+                       }
+             },


NIT: extra space

adbridge · 2018-01-02T10:45:24Z

tools/build_travis.py

+            {"target": "VK_RZ_A1H",
+             "toolchains": "GCC_ARM",
+             "tests": {""     : ["MBED_2", "MBED_10", "MBED_11", "MBED_16"],
+                       }


NIT: extra space

Once travis finishes I can fix these, I used formatting that was in the file (many of the lines have this).

adbridge · 2018-01-02T10:45:39Z

tools/build_travis.py

+             "toolchains": "GCC_ARM",
+             "tests": {""     : ["MBED_2", "MBED_10", "MBED_11", "MBED_16"],
+                       }
+             }


NIT: extra space

Travis: dsp only for cortex-m

Build api used to build cmsis separately (how mbed 2 is being build). This is currently not how cmsis is being defined. As there target dependencies in some cases, we should include paths from targets when building cmsis

Use mbed critical section

adbridge · 2018-01-02T11:49:42Z

Additional updates look good to me.

As it does not share the codebase with RZ A1H, it needs to be disabled until bring it up to date with the latest changes to cmsis. There are changes regarding caches, mmu and others

0xc0170 · 2018-01-02T12:59:16Z

/morph build

mbed-ci · 2018-01-02T13:38:04Z

Build : SUCCESS

Build number : 774
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5770/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-02T14:19:49Z

Exporter Build : SUCCESS

Build number : 427
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5770/

mbed-ci · 2018-01-02T14:40:47Z

Test : SUCCESS

Build number : 610
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5770/610

0xc0170 added the needs: review label Dec 31, 2017

0xc0170 requested a review from bulislaw December 31, 2017 09:41

0xc0170 commented Dec 31, 2017

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Dec 31, 2017

0xc0170 force-pushed the fix_rza1h branch from 63f6edd to 658336a Compare December 31, 2017 16:18

renesas: os tick only for rtos

3247a96

As this is os tick implementation for rtos, it should not be compilied if rtos not present (mbed 2)

0xc0170 force-pushed the fix_rza1h branch from 658336a to b5f20b2 Compare December 31, 2017 16:21

0xc0170 force-pushed the fix_rza1h branch from 7145f42 to 9609262 Compare January 1, 2018 20:54

0xc0170 force-pushed the fix_rza1h branch from 9609262 to def7f9d Compare January 2, 2018 08:02

0xc0170 changed the title ~~Renesas: fix cmsis device header and os tick target implementation~~ Renesas: fix cmsis lib build Jan 2, 2018

0xc0170 mentioned this pull request Jan 2, 2018

Release candidate for mbed-os-5.7.2 #5767

Merged

0xc0170 requested review from theotherjimmy and adbridge January 2, 2018 08:18

bulislaw approved these changes Jan 2, 2018

View reviewed changes

adbridge requested changes Jan 2, 2018

View reviewed changes

0xc0170 force-pushed the fix_rza1h branch from 5aa7a09 to e56b1d9 Compare January 2, 2018 11:46

0xc0170 added 3 commits January 2, 2018 11:48

Travis: add RZ_A1H target

038324a

Travis: dsp only for cortex-m

tools: cmsis and hal are build together

e07b3c7

Build api used to build cmsis separately (how mbed 2 is being build). This is currently not how cmsis is being defined. As there target dependencies in some cases, we should include paths from targets when building cmsis

VK RZ A1H: fix errors from the latest cmsis updates

fed5dd1

Use mbed critical section

VK RZ A1H: remove target from mbed 2 release

a8fc394

As it does not share the codebase with RZ A1H, it needs to be disabled until bring it up to date with the latest changes to cmsis. There are changes regarding caches, mmu and others

0xc0170 force-pushed the fix_rza1h branch from e56b1d9 to a8fc394 Compare January 2, 2018 11:51

adbridge approved these changes Jan 2, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Jan 2, 2018

adbridge added ready for merge release-version: 5.7.2 and removed needs: CI labels Jan 2, 2018

adbridge merged commit c832515 into ARMmbed:master Jan 2, 2018

adbridge removed the ready for merge label Jan 2, 2018

0xc0170 mentioned this pull request Jan 3, 2018

VK RZ A1H: needs an update from RZ A1H (cmsis, rtos related) #5777

Closed

Renesas: fix cmsis lib build #5770

Renesas: fix cmsis lib build #5770

Uh oh!

Conversation

0xc0170 commented Dec 31, 2017

Uh oh!

0xc0170 commented Dec 31, 2017

Uh oh!

mbed-ci commented Dec 31, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jan 1, 2018

Uh oh!

mbed-ci commented Jan 1, 2018

Triggering tests

Uh oh!

mbed-ci commented Jan 1, 2018

Uh oh!

mbed-ci commented Jan 1, 2018

Uh oh!

0xc0170 commented Jan 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adbridge left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adbridge commented Jan 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Jan 2, 2018

Uh oh!

mbed-ci commented Jan 2, 2018

Triggering tests

Uh oh!

mbed-ci commented Jan 2, 2018

Uh oh!

mbed-ci commented Jan 2, 2018

Uh oh!

Uh oh!

0xc0170 commented Jan 2, 2018 •

edited

Loading

adbridge commented Jan 2, 2018 •

edited

Loading