Skip to content

RTC test: fix __result variable #5784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Jan 4, 2018

Result was not defined, thus causing attribute error

AttributeError: 'RTC_time_calc_test' object has no attribute '_RTC_time_calc_test__result'

@mprse @maciejbocianski please review

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 4, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 4, 2018

Build : SUCCESS

Build number : 801
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5784/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 4, 2018

@@ -53,6 +53,7 @@ class RTC_time_calc_test(BaseHostTest):
year_id = 0


__result = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this will fix an AttributeError, it introduces further confusion. It's unnecessary to override result() method in RTC_time_calc_test class in the first place (the device side decides if the test suite passed or not). I suggest removing result() and teardown() methods from this class altogether.

def result(self):
return self.__result
def teardown(self):
pass

This way the code gets more readable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not sure what was the intention with having result method. I'll remove it, as soon as test is finished

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note:
From what I've seen this result() method gets called if DUT does not send {{end;success}} / {{end;failure}} which may happen e.g. on test suite timeout.

https://github.com/ARMmbed/htrun/blob/9648fd73930cfa86967833e85a0f2ef5efaf9cd5/mbed_host_tests/host_tests_runner/host_test_default.py#L467-L473

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, we are getting timeouts today, so that might needs patching as well

Not needed, neither used anywhere. Teardown also can
be removed
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 4, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 4, 2018

Build : FAILURE

Build number : 802
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5784/

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 4, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 4, 2018

Build : FAILURE

Build number : 803
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5784/

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 4, 2018

@studavekar @kegilbert Can you please investigate the build failure? From the logs, blinky example passes, but tls example cant be fetched (OSError), that leads to all these failures

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 4, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 4, 2018

Build : FAILURE

Build number : 804
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5784/

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 4, 2018

webpage mbed os problems, that are operational now. restarting

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 4, 2018

Build : SUCCESS

Build number : 805
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5784/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@cmonr cmonr self-requested a review January 4, 2018 16:37
@studavekar
Copy link
Contributor

/morph test

@mbed-ci
Copy link

mbed-ci commented Jan 4, 2018

@mbed-ci
Copy link

mbed-ci commented Jan 4, 2018

@adbridge
Copy link
Contributor

This file was only introduced in a PR which is scheduled for 5.8, thus this also needs to go to 5.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants