-
Notifications
You must be signed in to change notification settings - Fork 3k
RTC test: fix __result variable #5784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/morph build |
Build : SUCCESSBuild number : 801 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 455 |
TESTS/host_tests/rtc_calc_auto.py
Outdated
@@ -53,6 +53,7 @@ class RTC_time_calc_test(BaseHostTest): | |||
year_id = 0 | |||
|
|||
|
|||
__result = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this will fix an AttributeError
, it introduces further confusion. It's unnecessary to override result()
method in RTC_time_calc_test
class in the first place (the device side decides if the test suite passed or not). I suggest removing result()
and teardown()
methods from this class altogether.
mbed-os/TESTS/host_tests/rtc_calc_auto.py
Lines 134 to 138 in c832515
def result(self): | |
return self.__result | |
def teardown(self): | |
pass |
This way the code gets more readable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was not sure what was the intention with having result method. I'll remove it, as soon as test is finished
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note:
From what I've seen this result()
method gets called if DUT does not send {{end;success}}
/ {{end;failure}}
which may happen e.g. on test suite timeout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct, we are getting timeouts today, so that might needs patching as well
Not needed, neither used anywhere. Teardown also can be removed
397cc08
to
77cc7c7
Compare
/morph build |
Build : FAILUREBuild number : 802 |
/morph build |
Build : FAILUREBuild number : 803 |
@studavekar @kegilbert Can you please investigate the build failure? From the logs, blinky example passes, but tls example cant be fetched (OSError), that leads to all these failures |
/morph build |
Build : FAILUREBuild number : 804 |
webpage mbed os problems, that are operational now. restarting /morph build |
Build : SUCCESSBuild number : 805 Triggering tests/morph test |
/morph test |
Exporter Build : SUCCESSBuild number : 456 |
Test : SUCCESSBuild number : 637 |
This file was only introduced in a PR which is scheduled for 5.8, thus this also needs to go to 5.8. |
Result was not defined, thus causing attribute error
@mprse @maciejbocianski please review