Skip to content

Some enhancements for the USBHost feature and small bug fix #5800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 22, 2018

Conversation

abougouffa
Copy link
Contributor

@abougouffa abougouffa commented Jan 7, 2018

Notes:

  • Pull requests will not be accepted until the submitter has agreed to the contributer agreement.
  • This is just a template, so feel free to use/remove the unnecessary things

Description

  • Rewrite the USBHost module callbacks in the new form.
  • Fix a bug related to defining MAX_HUB_NB macro, the variable k is declared if the macro is not zero as you can see here, and after, used without testing MAX_HUB_NB which leads to undefined reference error durring compilation if MAX_HUB_NB=0.

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

Todos

  • Tests
  • Documentation (not needed)

Steps to test or reproduce

  • Define the MAX_HUB_NB as zero leads to a compilation error.
  • Compiling the USBHost leads to compilation warnings concerning the callbacks.

@mbed-ci
Copy link

mbed-ci commented Jan 7, 2018

Automatic CI verification build not done, please verify manually.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 16, 2018

Build : SUCCESS

Build number : 874
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5800/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 16, 2018

@mbed-ci
Copy link

mbed-ci commented Jan 16, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 16, 2018

@cmonr
Copy link
Contributor

cmonr commented Jan 18, 2018

Double checking. @adbridge @0xc0170 shouldn't this PR target ARMmbed:master instead of ARMmbed:mbed-os-5.7 ?

@adbridge
Copy link
Contributor

@cmonr Yes, we do not accept PRs against release branches...

@cmonr cmonr changed the base branch from mbed-os-5.7 to master January 18, 2018 18:59
@cmonr
Copy link
Contributor

cmonr commented Jan 18, 2018

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2018

Restarting CI, as it did not report back

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2018

Build : SUCCESS

Build number : 896
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5800/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2018

/morph export-build

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2018

/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2018

@studavekar
Copy link
Contributor

/morph test

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 13, 2018

Exporter Build : FAILURE

Build number : 1379
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5800/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants