Skip to content

Add MTB MXChip EMW3166 #5809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Add MTB MXChip EMW3166 #5809

merged 1 commit into from
Jan 23, 2018

Conversation

ashok-rao
Copy link
Contributor

@ashok-rao ashok-rao commented Jan 8, 2018

Description

Adding MXChip EMW3166 as a new target.

Status

READY

Migrations

NO

Todos

  • Tests
  • Documentation

Deploy notes

Needs addition of new hardware in CI.

@0xc0170 - can you please review the additions?

cc @screamerbg @chris-styles @studavekar

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 9, 2018

@ashok-rao Can you share the test results ?

@ashok-rao
Copy link
Contributor Author

ashok-rao commented Jan 9, 2018

Thanks for approving @0xc0170 .. For greentea, there is no DAPLink support available yet for the STM32F412 that is used on this module. So far, I have been using KEIL to flash the axf onto the target and check the Mbed OS port. Any ideas how to proceed with tests?

cc @screamerbg @chris-styles

Edit: PR is also raised for mbedls: ARMmbed/mbed-ls#287

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 10, 2018

Thanks for approving @0xc0170 .. For greentea, there is no DAPLink support available yet for the STM32F412 that is used on this module. So far, I have been using KEIL to flash the axf onto the target and check the Mbed OS port. Any ideas how to proceed with tests?

We shall wait for daplink firmware to test this addition

@ashok-rao
Copy link
Contributor Author

@c1728p9 .. can we please build a DAPLink for the EMW3166 with F412? It is currently built on F411. Thank you.

@c1728p9
Copy link
Contributor

c1728p9 commented Jan 11, 2018

can we please build a DAPLink for the EMW3166 with F412? It is currently built on F411.

@ashok-rao this isn't a supported DAPLink board currently, so I can't simply rebuild it.

@ashok-rao
Copy link
Contributor Author

Ok. So, we won't be able to run CI on this then..

@0xc0170 0xc0170 changed the title Adding MTB MXChip EMW3166 as a new target Add MTB MXChip EMW3166 Jan 15, 2018
@ashok-rao
Copy link
Contributor Author

@0xc0170 .. we got a DAPLink build for it from @c1728p9 for this module .. I ran greentea locally on it and attaching the results below.. All of them seem to be commonly failing in lp_ticker / timer .. I suspect this could be because we are using internal clocks on all these MCB's ? or is there something going on with greentea ? Could you please have a look? Thanks.

GT_IAR_EMW3166.txt
GT_ARMCC_EMW3166.txt
GT_GCC_EMW3166.txt

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 18, 2018

Build : SUCCESS

Build number : 893
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5809/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 18, 2018

@mbed-ci
Copy link

mbed-ci commented Jan 18, 2018

@ashok-rao
Copy link
Contributor Author

@0xc0170 ..thanks for triggering the test.. I cannot see the reason why exporter has failed. Looks like all PASS from the logs.. ??

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2018

/morph export-build

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2018

/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Jan 18, 2018

@ashok-rao
Copy link
Contributor Author

@0xc0170 Looks to me that it's failing on other different platforms while the MTB's are passing.. @studavekar @kegilbert

@cmonr
Copy link
Contributor

cmonr commented Jan 18, 2018

Rerunning export test. Looks like one of the exporter machines went offline too soon.

/morph export-build

@cmonr
Copy link
Contributor

cmonr commented Jan 18, 2018

@0xc0170, what's the particular reason for the Do Not Merge label?

@mbed-ci
Copy link

mbed-ci commented Jan 18, 2018

Exporter Build : SUCCESS

Build number : 569
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5809/

@ashok-rao
Copy link
Contributor Author

ashok-rao commented Jan 19, 2018

Woohhoo! Thanks @cmonr .
@0xc0170 ..over to you to take this PR further.

@ashok-rao
Copy link
Contributor Author

@0xc0170 ..bump!

@cmonr
Copy link
Contributor

cmonr commented Jan 22, 2018

@ashok-rao Is it still the case that this needs hardware in CI? Or is that still not possible due to the board not having a DAPlink interface?

@ashok-rao
Copy link
Contributor Author

@cmonr .. we have a DAPLink for this now & the tests have passed above.. It doesn't need new HW in CI.. So, should be good to go from my end. Thanks!

@cmonr cmonr merged commit 892e5e1 into ARMmbed:master Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants