Add COMMON folder for tests #5819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2018
A COMMON folder allows code reuse across different test cases. This avoids code duplication or code enterying the application space. The COMMON folder is uppercase to match naming conventions in Mbed OS.
+1, the pattern to match is |
|
looks good to me |
0xc0170
approved these changes
Jan 16, 2018
|
/morph build |
Build : SUCCESSBuild number : 879 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 551 |
Test : SUCCESSBuild number : 726 |
|
@studavekar Can you please review this from testing point of view? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #5524 for previous discussion
A COMMON folder allows code reuse across different test cases. This avoids code duplication or code entering the application space.
The COMMON folder is uppercase to match naming conventions in Mbed OS.
I'm open to feedback, also not very familiar with the layout of the tools in Mbed OS.
resolves #5524
resolves #5803
cc @bridadan, @theotherjimmy, @0xc0170