Python2+3: mbed compile, mbed test --compile, python unit tests #5848

theotherjimmy · 2018-01-12T22:02:09Z

Todo

Have Travis tests this in python 2.7, 3.5 and 3.6

theotherjimmy · 2018-01-25T15:35:34Z

@Nodraak Care to review while I work on getting testing working again?

theotherjimmy · 2018-01-25T16:59:39Z

This change is huge. So will the review list:

geky

Travis changes look good 👍

sarahmarshy · 2018-01-25T20:05:00Z

tools/arm_pack_manager/__init__.py

+try:
+    from Queue import Queue
+except ImportError:
+    from queue import Queue


sarahmarshy

print("Good work!")

0xc0170

Awesome !

0xc0170 · 2018-01-26T12:44:17Z

/morph build

mbed-ci · 2018-01-26T13:03:10Z

Build : FAILURE

Build number : 970
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5848/

theotherjimmy · 2018-01-26T16:35:27Z

@studavekar I'm not seeing any build failures there. Am I missing something?

studavekar · 2018-01-26T16:43:32Z

@studavekar I'm not seeing any build failures there. Am I missing something?

I can see below error in console logs

00:00:40.604 mbed-os test build passed, perform example builds
00:00:40.859 usage: examples.py compile [-h] [-m MCU] [--profile profile]
00:00:40.859                            [toolchains [toolchains ...]]
00:00:40.860 examples.py compile: error: argument toolchains: invalid parse_type value: 'ARM'

theotherjimmy · 2018-01-26T17:34:29Z

I had to go to Jenkins for that one I suppose.

bridadan

Great work! This is not a painless change but I'm really happy to see this happening!

bridadan · 2018-01-30T15:38:10Z

tools/build_everything.py

@@ -154,7 +154,7 @@
        test_builds = {}
        total_build_success = True

-        for target_name, target_toolchains in build_config.iteritems():
+        for target_name, target_toolchains in build_config.items():


Side note for this file, I'm not aware of anything that relies on this. It'd be good to double check that but I'm guessing this file could be removed in the future.

bridadan · 2018-01-30T16:11:03Z

tools/test/examples/examples_lib.py


-SUPPORTED_TOOLCHAINS = ["ARM", "IAR", "GCC_ARM", "ARMC6"]
+SUPPORTED_TOOLCHAINS = list(TOOLCHAINS - set(u'uARM'))


geky · 2018-01-30T16:18:09Z

Sorry, pretty bars made it in first. Looks like this will need a rebase. 😛

theotherjimmy · 2018-02-05T17:23:21Z

Done.
/morph build

mbed-ci · 2018-02-05T17:48:48Z

Build : SUCCESS

Build number : 1065
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5848/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

cmonr · 2018-02-05T18:22:03Z

/morph uvisor-test

mbed-ci · 2018-02-05T18:48:55Z

Exporter Build : SUCCESS

Build number : 743
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5848/

cmonr · 2018-02-05T19:29:10Z

/morph uvisor-test

cmonr · 2018-02-05T19:46:53Z

/morph uvisor-test

mbed-ci · 2018-02-05T20:18:56Z

Test : SUCCESS

Build number : 872
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5848/872

0xc0170 · 2018-02-05T20:26:44Z

/morph uvisor-test

adbridge · 2018-02-23T16:19:20Z

This relies on changes introduced in #5022 which is targeted for 5.8.

theotherjimmy · 2018-02-23T16:22:03Z

@adbridge It's not that it "relies on" it, it was just rebased on top of those changes, and modified the same code.

theotherjimmy changed the title ~~Python2+3: Mbed Compile + python unit tests~~ Python2+3: mbed compile, mbed test --compile, python unit tests Jan 12, 2018

theotherjimmy force-pushed the compile-py3 branch 3 times, most recently from 2d84302 to 4576a73 Compare January 13, 2018 00:08

theotherjimmy added the needs: work label Jan 14, 2018

theotherjimmy force-pushed the compile-py3 branch 5 times, most recently from 1838dd8 to 19545f4 Compare January 25, 2018 15:35

theotherjimmy added needs: review and removed needs: work labels Jan 25, 2018

geky approved these changes Jan 25, 2018

View reviewed changes

sarahmarshy reviewed Jan 25, 2018

View reviewed changes

sarahmarshy approved these changes Jan 25, 2018

View reviewed changes

0xc0170 approved these changes Jan 26, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Jan 26, 2018

0xc0170 added needs: work and removed needs: CI labels Jan 26, 2018

theotherjimmy force-pushed the compile-py3 branch from b639381 to 0275b6f Compare January 26, 2018 17:34

bridadan approved these changes Jan 30, 2018

View reviewed changes

theotherjimmy added 8 commits February 5, 2018 11:04

Python2+3: iteritems -> items

cca4425

Python2+3: tests passing

4322bee

Python2+3: Use absolute import where possible

c93a2bf

Python2+3: mbed test --compile

1dd39fb

Python2+3: make.py -n

424ad85

Python2+3: build_travis.py and Travis tests

db4c380

Compare to unicode in example builder

95c7d4d

Python2+3: flash_algo

2d50a90

theotherjimmy force-pushed the compile-py3 branch from 0275b6f to 2d50a90 Compare February 5, 2018 17:13

cmonr added ready for merge and removed needs: work labels Feb 6, 2018

cmonr merged commit c679dee into ARMmbed:master Feb 7, 2018

cmonr removed the ready for merge label Feb 7, 2018

cmonr added the release-version: 5.7.6 label Feb 20, 2018

adbridge added release-version: 5.8.0-rc1 and removed release-version: 5.7.6 labels Feb 23, 2018

This was referenced Feb 23, 2018

Add exporter for Analog Devices' CrossCore Embedded Studio #5666

Merged

tools: Let unicode error messages through #6154

Merged

This was referenced Feb 23, 2018

Travis: Fix tools testing breakage due to multiple python versions #6200

Closed

Travis: Tear out python3 testing to get CI working again #6218

Merged


		SUPPORTED_TOOLCHAINS = ["ARM", "IAR", "GCC_ARM", "ARMC6"]
		SUPPORTED_TOOLCHAINS = list(TOOLCHAINS - set(u'uARM'))

Python2+3: mbed compile, mbed test --compile, python unit tests #5848

Python2+3: mbed compile, mbed test --compile, python unit tests #5848

Uh oh!

Conversation

theotherjimmy commented Jan 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Todo

Uh oh!

theotherjimmy commented Jan 25, 2018

Uh oh!

theotherjimmy commented Jan 25, 2018

Uh oh!

geky left a comment

Choose a reason for hiding this comment

Uh oh!

sarahmarshy Jan 25, 2018

Choose a reason for hiding this comment

Uh oh!

sarahmarshy left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Jan 26, 2018

Uh oh!

mbed-ci commented Jan 26, 2018

Build : FAILURE

Uh oh!

theotherjimmy commented Jan 26, 2018

Uh oh!

studavekar commented Jan 26, 2018

Uh oh!

theotherjimmy commented Jan 26, 2018

Uh oh!

bridadan left a comment

Choose a reason for hiding this comment

Uh oh!

bridadan Jan 30, 2018

Choose a reason for hiding this comment

Uh oh!

bridadan Jan 30, 2018

Choose a reason for hiding this comment

Uh oh!

geky commented Jan 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theotherjimmy commented Feb 5, 2018

Uh oh!

mbed-ci commented Feb 5, 2018

Build : SUCCESS

Triggering tests

Uh oh!

cmonr commented Feb 5, 2018

Uh oh!

mbed-ci commented Feb 5, 2018

Exporter Build : SUCCESS

Uh oh!

cmonr commented Feb 5, 2018

Uh oh!

cmonr commented Feb 5, 2018

Uh oh!

mbed-ci commented Feb 5, 2018

Test : SUCCESS

Uh oh!

0xc0170 commented Feb 5, 2018

Uh oh!

adbridge commented Feb 23, 2018

Uh oh!

theotherjimmy commented Feb 23, 2018

Uh oh!

Uh oh!

theotherjimmy commented Jan 12, 2018 •

edited

Loading

geky commented Jan 30, 2018 •

edited

Loading