Allow overriding of DCDC settings per target #5855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a way to configure |
Allow custom targets to override the DCDC settings by defining EMU_DCDCINIT_STK_DEFAULT to target-specific initialization values.
stevew817
force-pushed
the
feature/new/allow_dcdc_override
branch
from
5c279e8 to
18c973f
Compare
|
@amq good catch, added! Define EMU_NO_DCDC :) |
|
LGTM |
0xc0170
approved these changes
Jan 15, 2018
|
/morph build |
Build : SUCCESSBuild number : 871 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 541 |
Test : SUCCESSBuild number : 717 |
|
/morph uvisor-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow custom targets to override the DCDC settings by defining EMU_DCDCINIT_STK_DEFAULT to target-specific initialization values. This feature was requested in #5783
Status
READY
Migrations
Custom targets need to define EMU_DCDCINIT_STK_DEFAULT if they need different DCDC initialisation settings versus the defaults in em_emu.h