-
Notifications
You must be signed in to change notification settings - Fork 3k
Add missing free function to lp and us ticker HAL APIs #5856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Does this need to go to feature branch and have all targets implemented? If this API is defined, shouldn't be used somewhere? Us ticker is always running at the moment (overflow to count 64bit timestamp) - how does this work with this extension? Shall lp ticker be disabled? |
It should go to the ticker feature branch until it's implemented on the necessary boards. The tickers should stop counting after being freed if they were initialised, I'm not certain of the behaviour yet if multiple tickers rtc/us/lp are running and share the same counter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to rebase your code on top of the rtos ticker branch and update the undefined behaviour section on the beginning of the header.
@scartmell-arm Please advice what is the destination branch, still points to master - seems incorrect. |
a2a3aab
to
2ae20ca
Compare
@scartmell-arm Can you rebase please after changing the destination branch? |
Could you explain how and when the ticker free function is supposed to be used ? A module calling |
We are adding way of powering things off to all HAL APIs, the driver will need to figure out how to use it. I'm not sure it will be possible to do for all the drivers for Mbed OS 5, due to backward compatibility requirements. As for us ticker I don't want it being used by Mbed OS if we can avoid it, therefore it will be up to the user to manage it's lifetime. |
/morph build |
Build : SUCCESSBuild number : 958 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 643 |
Test : SUCCESSBuild number : 785 |
/morph uvisor-test |
Description
The current HAL specification for tickers does not provide a method to disable them, which is an issue for low power mode. This PR adds free functions similar to that defined in the RTC HAL API to both the us ticker and lp ticker APIs.
Status
IN DEVELOPMENT
Migrations
NO
Todos