STM32 LPT optimisation #5862
Merged
STM32 LPT optimisation #5862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
reviewed
Jan 16, 2018
targets/TARGET_STM/rtc_api.c
Outdated
| @@ -123,6 +124,10 @@ void rtc_init(void) | |||
| RtcHandle.Init.OutPutType = RTC_OUTPUT_TYPE_OPENDRAIN; | |||
| #endif /* TARGET_STM32F1 */ | |||
|
|
|||
| #if DEVICE_LOWPOWERTIMER && !MBED_CONF_TARGET_LOWPOWERTIMER_LPTIM | |||
| lp_TickPeriod_us = 2048 * 1000000 / RtcHandle.Init.SynchPrediv; | |||
There was a problem hiding this comment.
where is 2048 coming from ? would it make sense to have a macro here with name that would explain ?
jeromecoutant
force-pushed
the
PR_LPT_ISSUE
branch
from
d9ebe30 to
9fb865a
Compare
0xc0170
approved these changes
Jan 16, 2018
|
/morph build |
Build : SUCCESSBuild number : 878 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 550 |
Test : SUCCESSBuild number : 725 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For each low power timer/ticker start, lp_ticker_read function is called 3 or 4 times.
lp_ticker_read duration was around 58us.
It is now reduced to 9us.
Hope it will solve #5790
Status
READY