-
Notifications
You must be signed in to change notification settings - Fork 3k
CoAP v4.1.1 #5864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoAP v4.1.1 #5864
Conversation
@yogpan01 @anttiylitokola @teetak01 please review. |
LGTM |
@JaniSuonpera Please add this to the git commit message for clear description of what this PR fixes
|
This PR implement https://tools.ietf.org/html/rfc7959#section-2.5 "The error code 4.13 (Request Entity Too Large) can be returned at any time by a server that does not currently have the resources to store blocks for a block-wise request payload transfer that it would intend to implement in an atomic fashion. (Note that a 4.13 response to a request that does not employ Block1 is a hint for the client to try sending Block1, and a 4.13 response with a smaller SZX in its Block1 Option than requested is a hint to try a smaller SZX.)
e0b3edb
to
fe80b67
Compare
PR updated, please review the latest addition |
There is coming fix. Small regression detected with internal testing. |
- New API to control whether coap itself sends a next GET(block2) request or not - Fixes error IOTCLT-2203 mbed-coap does not handle PUT or POST if they indicate a smaller block size preference
Combined CoAP changes 4.0.11 and 4.1.0 Fixed regression with 4.0.11
This contains now PR #5865 |
@JaniSuonpera, please update the changelog as well. |
Can that one be closed and we proceed this one? |
/morph build |
Build : SUCCESSBuild number : 897 Triggering tests/morph test |
I think that we can close PR #5865. |
Exporter Build : SUCCESSBuild number : 572 |
Changelog file updated. |
/morph build |
@0xc0170, When will be the next mbed-os release and can we get this fix included? |
The next week. Yes, waiting for CI to be completed |
/morph build |
Build : SUCCESSBuild number : 906 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 581 |
Test : SUCCESSBuild number : 748 |
This includes check Entity Too Large check for block1 and request server to resend data with supported block size.
New API to control whether coap itself sends a next GET(block2) request or not
Fixes error IOTCLT-2203 mbed-coap does not handle PUT or POST if they indicate a smaller block size preference
Status
*READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO