Skip to content

CoAP v4.1.1 #5864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 23, 2018
Merged

CoAP v4.1.1 #5864

merged 4 commits into from
Jan 23, 2018

Conversation

JaniSuonpera
Copy link
Contributor

@JaniSuonpera JaniSuonpera commented Jan 17, 2018

This includes check Entity Too Large check for block1 and request server to resend data with supported block size.

New API to control whether coap itself sends a next GET(block2) request or not
Fixes error IOTCLT-2203 mbed-coap does not handle PUT or POST if they indicate a smaller block size preference

Status

*READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

@JaniSuonpera
Copy link
Contributor Author

@yogpan01 @anttiylitokola @teetak01 please review.

@anttiylitokola
Copy link
Contributor

LGTM

@yogpan01
Copy link
Contributor

@JaniSuonpera Please add this to the git commit message for clear description of what this PR fixes

This PR implement https://tools.ietf.org/html/rfc7959#section-2.5
"The error code 4.13 (Request Entity Too Large) can be returned at any
time by a server that does not currently have the resources to store
blocks for a block-wise request payload transfer that it would intend
to implement in an atomic fashion. (Note that a 4.13 response to a
request that does not employ Block1 is a hint for the client to try
sending Block1, and a 4.13 response with a smaller SZX in its Block1
Option than requested is a hint to try a smaller SZX.)

@yogpan01
Copy link
Contributor

@0xc0170 @adbridge FYI

This PR implement https://tools.ietf.org/html/rfc7959#section-2.5
"The error code 4.13 (Request Entity Too Large) can be returned at any
time by a server that does not currently have the resources to store
blocks for a block-wise request payload transfer that it would intend
to implement in an atomic fashion. (Note that a 4.13 response to a
request that does not employ Block1 is a hint for the client to try
sending Block1, and a 4.13 response with a smaller SZX in its Block1
Option than requested is a hint to try a smaller SZX.)
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 17, 2018

PR updated, please review the latest addition

@JaniSuonpera
Copy link
Contributor Author

There is coming fix. Small regression detected with internal testing.

Antti Yli-Tokola and others added 2 commits January 18, 2018 16:00
 - New API to control whether coap itself sends a next GET(block2) request or not
 - Fixes error IOTCLT-2203 mbed-coap does not handle PUT or POST if they indicate a smaller block size preference
Combined CoAP changes 4.0.11 and 4.1.0
Fixed regression with 4.0.11
@JaniSuonpera JaniSuonpera changed the title CoAP v4.0.11 CoAP v4.1.1 Jan 18, 2018
@JaniSuonpera
Copy link
Contributor Author

This contains now PR #5865

@anttiylitokola
Copy link
Contributor

@JaniSuonpera, please update the changelog as well.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2018

This contains now PR #5865

Can that one be closed and we proceed this one?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2018

Build : SUCCESS

Build number : 897
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5864/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@JaniSuonpera
Copy link
Contributor Author

I think that we can close PR #5865.

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2018

@JaniSuonpera
Copy link
Contributor Author

Changelog file updated.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 22, 2018

/morph build

@anttiylitokola
Copy link
Contributor

@0xc0170, When will be the next mbed-os release and can we get this fix included?

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 22, 2018

@0xc0170, When will be the next mbed-os release and can we get this fix included?

The next week. Yes, waiting for CI to be completed

@kegilbert
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 22, 2018

Build : SUCCESS

Build number : 906
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5864/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 22, 2018

@mbed-ci
Copy link

mbed-ci commented Jan 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants