Skip to content

RTX idle: sleep without locked deep sleep fix #5866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Jan 17, 2018

I could not find a reason from the logs why this locking was present if tickless is enabled.

Please review

If tickless is enabled, it should not be locking deepsleep
@jeromecoutant
Copy link
Collaborator

Maybe because os_timer is not a lp_timer, so tick count is stopped during deepsleep ?

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 17, 2018

Maybe because os_timer is not a lp_timer, so tick count is stopped during deepsleep ?

os timer is lp ticker by default

This is more related to how fast can a target wake up from deep sleep, not defined for the current version (see sleep feature branch). Therefore this should stay as it is. But the documentation should state this limitation that even with tickless mode, we only sleep for now

I read some bug reports regarding sleep (2 reports within the last days ) and was notified about sleep manager confusion between docs and code.

To resolve this, this code change is not accepted, and we will update Handbook to add a description about the sleep manager in the idle loop? Let me know what you think, I can send Handbook update

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 17, 2018

https://os.mbed.com/docs/v5.7/reference/sleep-manager.html - this is the handbook sleep manager page
Example 1 there:

    // Sleep for 1 second
    printf("Deep sleep allowed: %i\r\n", sleep_manager_can_deep_sleep());
    wait(1.0);

Eventhough deep sleep is enabled in the main app, it would not deepsleep.

Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think about anything neither. If it passes all the tests then we are OK.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 22, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 22, 2018

Build : FAILURE

Build number : 904
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5866/

@kegilbert
Copy link
Contributor

/morph build

1 similar comment
@cmonr
Copy link
Contributor

cmonr commented Jan 22, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 22, 2018

Build : SUCCESS

Build number : 913
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5866/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@cmonr
Copy link
Contributor

cmonr commented Jan 23, 2018

Jenkins didn't report abort.

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 23, 2018

@mbed-ci
Copy link

mbed-ci commented Jan 23, 2018

@mbed-ci
Copy link

mbed-ci commented Jan 23, 2018

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 23, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 23, 2018

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 23, 2018

Eclipse error after cleaning up the workspace

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants