lpc546xx and ff_lpc546xx: create parent object MCU_LPC546XX #5876
Conversation
|
Automatic CI verification build not done, please verify manually. |
|
cc @ashok-rao |
targets/targets.json
Outdated
| "FF_LPC546XX": { | ||
| "inherits": ["LPC546XX"], | ||
| "inherits": ["MCU_LPC546XX"], | ||
| "extra_labels_add" : ["LPC546XX"], |
There was a problem hiding this comment.
Why is this label needed and not present in the parent, neither LPC546XX does need it?
There was a problem hiding this comment.
fixed, both targets need it (target LPC546XX adds it by default)
Still causing the problems with the latest update? |
|
It doesnt work with mbed version 157. I havent tested 242ce29 against the error. How do i point online compiler to it? |
you can fork mbed-os there and use your own modified version for instance |
yes i am familiar with that. Although i need to fork mbed (not mbed-os). So i need to fork this with source files. Where is the fork button? Anyway, i moved the mbed repo to github and imported the lib from there. This PR does not solve the error:
|
|
Changing device name does not work either: It does work if i remove or rename the LPC546XX folder: I am closing this PR and opening an issue for that. |
|
User not whitelisted, CI not run. |
|
Reopening this PR. See #5887. |
|
/morph build |
Build : SUCCESSBuild number : 1060 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 739 |
Test : FAILUREBuild number : 866 |
|
network error for one device, restarting /morph test |
Test : SUCCESSBuild number : 870 |
|
rebased |
|
/morph build |
Build : SUCCESSBuild number : 1070 Triggering tests/morph test |
Test : SUCCESSBuild number : 878 |
Exporter Build : SUCCESSBuild number : 748 |
Abstract
ff_lpc546xx currently inherits from target lpc546xx. This results in error in mbed online compiler:
Error: Library name 'platform' is not unique (defined in '/extras/mbed_7130f322cb7e/TARGET_LPC546XX/mbed_lib.json' and '/extras/mbed_7130f322cb7e/TARGET_FF_LPC546XX/mbed_lib.json')when compiling examples with mbed library (compiling with mbed-os works fine).
Status: READY
Priority: High