Skip to content

Ticker requirement and test update #5884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 19, 2018
Merged

Ticker requirement and test update #5884

merged 3 commits into from
Jan 19, 2018

Conversation

mprse
Copy link
Contributor

@mprse mprse commented Jan 19, 2018

Description

This PR contains:

  • modification of the requirement for the ticker init function (result of the following discussion Add tests for ticker HAL API. #5233 (review)).
  • update of the test case to be consistent with new requirement.
  • fix in the us/lp ticker test implementation (The intention was to use ticker_overflow_delta equal to 0 for low power ticker tests and ticker_overflow_delta equal to 50 for high frequency ticker tests. Current implementation is invalid since for devices which provide LOW_POWER_TIMER feature delta is equal to 0 and for devices without this feature delta is equal 50.)

Status

READY

Migrations

NO

Related PRs

mprse added 3 commits January 19, 2018 08:07
@mprse
Modify requirement for the ticker_init function.
e1489a7 
Current version:
The function ticker_init resets the internal count and disables the ticker interrupt.

Proposed version:
The function ticker_init allows the ticker to keep counting and disables the ticker interrupt.

This is a result of the following discussion:
ARMmbed#5233 (review)
@mprse
Modify ticker_init_test() to be consistent with the new requirement.
543d98b
@mprse
Provide fix to the implementation of ticker_overflow_test test case.
e0a2f0d 
The intention was to use ticker_overflow_delta equal to 0 for low power ticker tests and ticker_overflow_delta equal to 50 for high frequency ticker tests. Current implementation is invalid since for devices which provide LOW_POWER_TIMER feature delta is equal to 0 and for devices without this feature delta is equal 50.
@mprse mprse mentioned this pull request Jan 19, 2018
Merged
@jeromecoutant
Copy link
Collaborator

Thx @mprse for the ticker init part

jamesbeyond
jamesbeyond approved these changes Jan 19, 2018
View reviewed changes
Copy link
Contributor

@jamesbeyond jamesbeyond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, well done!

@cmonr
Copy link
Contributor

cmonr commented Jan 19, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2018

Build : SUCCESS

Build number : 901
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5884/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2018

Exporter Build : SUCCESS

Build number : 577
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5884/

@mbed-ci
Copy link

mbed-ci commented Jan 19, 2018

Test : SUCCESS

Build number : 743
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5884/743

@cmonr cmonr merged this pull request into ARMmbed:feature-hal-spec-ticker Jan 19, 2018
@cmonr cmonr removed the needs: CI label Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesbeyond jamesbeyond jamesbeyond approved these changes

@c1728p9 c1728p9 Awaiting requested review from c1728p9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mprse @jeromecoutant @cmonr @mbed-ci @jamesbeyond @0xc0170