-
Notifications
You must be signed in to change notification settings - Fork 3k
Simplify and Improve error/warning parser for gcc_arm #5915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Automatic CI verification build not done, please verify manually. |
Hi, can you please sign https://os.mbed.com/contributor_agreement/ |
Hi, I signed, I thought the pdf per mail was enough |
@theotherjimmy Think you could take a quick look at this? |
The new code just reads that from the line, doesn't it? |
note: mcu can be provided on the CLI with |
as this must be profile agnostic, why did you include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supposing this is confirmed to work with more than --profile release
(it should, I just want to check)
/morph build |
@DBS06 How did you test (all profiles) ? |
Build : SUCCESSBuild number : 1086 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 763 |
Test : SUCCESSBuild number : 893 |
Waiting on reply from @DBS06 |
Passed all tests, green |
Description
Simplify parsing of error and warning messages for GCC_ARM.
First, the parsing method is a little bit confusing and hacky and sometimes the column parsing by calculating the ^ position fails and on the output it shows "0" instead of the correct warning/error column. Instead I am parsing the column out of the gcc_arm output.
Second, the regex for the "INDEX_PATTERN" is not necessary anymore.
Status
READY
Migrations
NO
Steps to test or reproduce
mbed compile -t GCC_ARM --profile release
note: mcu (TARGET) must/should be configured in ".mbed"