Correct nsapi_dns_query_multiple()
#5946
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@betzw Thank you, I was just reviewing 5945 that is addressing the same (few minutes earlier PR). @kjbracey-arm |
|
Closed in favor of #5945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All the public overloads of nsapi_dns_query_multiple() are broken. They are documented as returning the number of addresses found on success. However, the return value of dns_scan_response() is not passed down, only its sign is checked and the function always returns NSAPI_ERROR_OK, i.e. zero.
This is especially disastrous for all the overloads that take SocketAddress * as argument; this overload expects the static variant to work as documented, which causes none of the addresses to be copied.
This PR resolves this issue (#5921)
Status
READY