VS Code exporter: do not overwrite existing (launch|settings|tasks).json #5964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer our configuration / tasks to be added to the existing json files, but I can live with this change. |
|
@janjongboom Is that an approval? |
theotherjimmy
approved these changes
Jan 30, 2018
|
/morph build |
Build : SUCCESSBuild number : 1033 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 714 |
0xc0170
approved these changes
Feb 1, 2018
Test : SUCCESSBuild number : 840 |
|
Merging since
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevents overwriting VS Code files which are customizable by the user.
launch.jsonis used to define the debugger and target,settings.jsonincludes all possible project-specific VS Code settings,tasks.jsondefines the build tasks.The only file which is still being overwritten is the list of includes:
c_cpp_properties.jsonFixes #5958
Status
READY
Migrations
NO