Skip to content

Pre-processor common macro addition #5987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2018
Merged

Pre-processor common macro addition #5987

merged 1 commit into from
Feb 1, 2018

Conversation

deepikabhavnani
Copy link

Added macros:

  1. Calculate string length MBED_STRLEN()
  2. Calculate variable arguments MBED_COUNT_VA_ARGS()

cmonr
cmonr reviewed Feb 1, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which compilers has this been tested with?

platform/mbed_preprocessor.h
* Reports number of tokens passed
*
* @note
* Token limit is 16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this limit?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason for 16, we can have higher but will need some limit for macro to work

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In current state, if arguments more then 16 are passed response will be 16 the max limit

@deepikabhavnani
Copy link
Author

Which compilers has this been tested with?

IAR, GCC, ARM

@cmonr
Copy link
Contributor

cmonr commented Feb 1, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 1, 2018

Build : SUCCESS

Build number : 1031
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5987/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Feb 1, 2018

Exporter Build : SUCCESS

Build number : 712
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5987/

@mbed-ci
Copy link

mbed-ci commented Feb 1, 2018

Test : SUCCESS

Build number : 839
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5987/839

@0xc0170 0xc0170 requested a review from SenRamakri February 1, 2018 08:18
@cmonr cmonr merged commit d8aebba into ARMmbed:master Feb 1, 2018
@deepikabhavnani deepikabhavnani deleted the add_macros branch February 1, 2018 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@SenRamakri SenRamakri SenRamakri approved these changes

Assignees
No one assigned
Labels
release-version: 5.7.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deepikabhavnani @cmonr @mbed-ci @0xc0170 @SenRamakri