-
Notifications
You must be signed in to change notification settings - Fork 3k
Adding LAIRD_BL600 MTB #5996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding LAIRD_BL600 MTB #5996
Conversation
I'm curious what others think. To me, lines 153 and 154 in TESTS/mbed_drivers/ticker/main.cpp should be swapped to prevent a potential race condition. |
@geky @theotherjimmy @0xc0170 ..what do you guys think? |
@cmonr It acts over serial, so that was probably done to reduce the jitter due to serial transmission. |
#5971 might resolve the issue? If not, please comment there |
@0xc0170 .. thanks for providing the link to PR #5971. Happy to confirm that the ticker tests are now passing with those changes to the /TESTS/mbed_drivers/ticker/main.cpp applied locally. Please find the passing logs attached below: MTB_BL600_GT_GCC_ticker_PASS.txt I think this PR can now be taken forward for review / CI. Thanks! |
/morph build |
Build : SUCCESSBuild number : 1082 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 759 |
Test : SUCCESSBuild number : 889 |
Description
Adding Laird BL600 as a new target.
Status
READY
Todos
@0xc0170 .. attaching GT logs below. Please note from the logs that only 1 test case "Test timers: 2x callbacks" in the suite "mbed-os-tests-mbed_drivers-ticker" is failing in both GCC and IAR while rest all tests are passing. ARMCC however passes everything. Any thoughts on this will be helpful. Thank you.
MTB_BL600_GT_ARMCC_Pass.txt
MTB_BL600_GT_GCC_Fail.txt
MTB_BL600_GT_IAR_Fail.txt
cc @screamerbg @chris-styles @studavekar