Skip to content

Adding LAIRD_BL600 MTB #5996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2018
Merged

Adding LAIRD_BL600 MTB #5996

merged 2 commits into from
Feb 8, 2018

Conversation

ashok-rao
Copy link
Contributor

@ashok-rao ashok-rao commented Feb 1, 2018

Description

Adding Laird BL600 as a new target.

Status

READY

Todos

  • Tests
  • Documentation

@0xc0170 .. attaching GT logs below. Please note from the logs that only 1 test case "Test timers: 2x callbacks" in the suite "mbed-os-tests-mbed_drivers-ticker" is failing in both GCC and IAR while rest all tests are passing. ARMCC however passes everything. Any thoughts on this will be helpful. Thank you.

MTB_BL600_GT_ARMCC_Pass.txt
MTB_BL600_GT_GCC_Fail.txt
MTB_BL600_GT_IAR_Fail.txt

cc @screamerbg @chris-styles @studavekar

@cmonr
Copy link
Contributor

cmonr commented Feb 1, 2018

I'm curious what others think. To me, lines 153 and 154 in TESTS/mbed_drivers/ticker/main.cpp should be swapped to prevent a potential race condition.

@ashok-rao
Copy link
Contributor Author

@geky @theotherjimmy @0xc0170 ..what do you guys think?

@theotherjimmy
Copy link
Contributor

@cmonr It acts over serial, so that was probably done to reduce the jitter due to serial transmission.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 5, 2018

#5971 might resolve the issue? If not, please comment there

@ashok-rao
Copy link
Contributor Author

ashok-rao commented Feb 6, 2018

@0xc0170 .. thanks for providing the link to PR #5971. Happy to confirm that the ticker tests are now passing with those changes to the /TESTS/mbed_drivers/ticker/main.cpp applied locally. Please find the passing logs attached below:

MTB_BL600_GT_GCC_ticker_PASS.txt
MTB_BL600_GT_IAR_ticker_PASS.txt

I think this PR can now be taken forward for review / CI. Thanks!

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 7, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 7, 2018

Build : SUCCESS

Build number : 1082
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5996/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Feb 7, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 7, 2018

@ashok-rao
Copy link
Contributor Author

Thank you @cmonr .. @0xc0170 can this go into 5.7.5 as well please?

@0xc0170 0xc0170 merged commit 9f6eb14 into ARMmbed:master Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants