Skip to content

Restrict target_overrides usage #5998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2018

Conversation

theotherjimmy
Copy link
Contributor

This will prevent a user from doing the invalid:

{
   "target_overrides": {
        "*": {
            "foo": {},
            "foo.foo.foo": true
        }
}

@cmonr
Copy link
Contributor

cmonr commented Feb 1, 2018

For context, why is the above pattern bad?

Is foo.foo.foo not considered its own thing?

@pan- pan- changed the title Restrict target_overries usage Restrict target_overrides usage Feb 2, 2018
@theotherjimmy
Copy link
Contributor Author

theotherjimmy commented Feb 2, 2018

@cmonr We only have a 2 level hierarchy: {libname|target|app}.parameter

@theotherjimmy
Copy link
Contributor Author

Further, setting a configuration parameter to {} is not allowed. Both lines generate errors (at the same time)

@cmonr
Copy link
Contributor

cmonr commented Feb 2, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 2, 2018

Build : SUCCESS

Build number : 1050
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5998/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Feb 2, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants