fix for issue "serial example callback not working" #6009
Conversation
| void serial_irq_handler(serial_t *obj, uart_irq_handler handler, uint32_t id) | ||
| { | ||
|
|
||
| #ifdef CONFIG_MBED_ENABLED |
There was a problem hiding this comment.
why CONFIG_MBED_ENABLED is here needed?
There was a problem hiding this comment.
I have just updated the description
There was a problem hiding this comment.
Thanks
The "CONFIG_MBED_ENABLED" macro has been put so that the software is compatible with our own internal SDK.
I can see it is used in this file. I just do not follow how is it used. If config is enabled then what changes ? Why serial_api.c depends on the config enabled?
There was a problem hiding this comment.
We are reusing the same file in our internal SDK and within realtek, we are trying to maintain one single repository structure for all projects so when we build our SDK, it would refer to this same file. Our loguart is slightly different in nature and hence the changes
|
Can you amend the commit message to provide more details how it is being fixed please? It would be helpful. |
|
As soon as the commit contains info about the fix, we will run CI |
Fix Details: HAL API for loguart is different that UART. Initially we didnt have support for loguart in the mbed api. These changes have been made to support the loguart from the mbed api by using the correct HAL api calls
prashantrar
force-pushed
the
mbed-os-serial-fix-pr
branch
from
0724011 to
011dbff
Compare
|
I have updated the commit message just now, please let me know if any extra information is needed. |
Thanks, but the details were added to the style change not the fix? |
|
We will squash these 2 commits into one /morph build |
Build : SUCCESSBuild number : 1134 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 811 |
Test : SUCCESSBuild number : 942 |
Description
This PR fixes issue #5805. The changes have been made only in one file.
The "CONFIG_MBED_ENABLED" macro has been put so that the software is compatible with our own internal SDK.
The other changes is to add support for loguart hardware in the normal serial api.
Status
READY/
Migrations
NO